Skip to content

Conversation

@mabe13
Copy link
Collaborator

@mabe13 mabe13 commented Feb 23, 2024

Task Branch Pull Request

https://nhsd-jira.digital.nhs.uk/browse/DS-2244

Description of Changes

This change adds a penetration test profile call pen.mk. This profile is based of the dev.mk profile but enables the WAF.

Copy link
Contributor

@JackPlowman JackPlowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JackPlowman JackPlowman self-requested a review February 23, 2024 13:49
@JackPlowman JackPlowman changed the title DS-2244 Add new pen test profile DS-2244 Add Penetration Test Make Profile Feb 23, 2024
JackPlowman
JackPlowman previously approved these changes Feb 23, 2024
Copy link
Contributor

@JackPlowman JackPlowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mabe13 mabe13 enabled auto-merge (squash) February 23, 2024 13:51
@mabe13 mabe13 force-pushed the task/DS-2244_Pen_test_profile branch from dce7372 to 6d940e9 Compare February 23, 2024 14:37
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@JackPlowman JackPlowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mabe13 mabe13 merged commit 5d5c9ee into develop Feb 23, 2024
@mabe13 mabe13 deleted the task/DS-2244_Pen_test_profile branch February 23, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants