DS-2400 Integration Test and Unit Python package Bug #1011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Branch Pull Request
https://nhsd-jira.digital.nhs.uk/browse/DS-2400
Description of Changes
This fixes an issue with a python package after an update to a dependency removed a underlying function. Fixed by removing pytest-bdd package version pinning.
Also included in this PR is a temp fix for the build image codebuild jobs. A 20 second sleep has been put in place to give time for the aws ecr security image scan to be ready, before it's checked.
Type of change
Delete not appropriate
Development Checklist
Code Reviewer Checklist