Skip to content

Conversation

@mabe13
Copy link
Collaborator

@mabe13 mabe13 commented May 22, 2024

Task Branch Pull Request

https://nhsd-jira.digital.nhs.uk/browse/DS-2622

Description of Changes

Removes ECR vulnerability scan check from PR release codebuild job used to build and test release in an environment.

Reason from removal can be found in the ticket.

Type of change

Delete not appropriate

  • Bug fix (non-breaking change which fixes an issue)

Development Checklist

  • I have performed a self-review of my own code
  • Tests have added that prove my fix is effective or that my feature works (Integration tests)
  • I have updated Dependabot to include my changes (if applicable)

Code Reviewer Checklist

  • I can confirm the changes have been tested or approved by a tester

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mabe13 mabe13 requested a review from Tomdango May 22, 2024 17:39
@mabe13 mabe13 merged commit 2fc0735 into develop May 23, 2024
@mabe13 mabe13 deleted the task/DS-2622_Remove_image_scan_check_from_release_pr_job branch May 23, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants