Skip to content

DS-2622 Remove ECR vulnerability scan check from development codepipeline #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mabe13 merged 1 commit into from
May 23, 2024
Merged

DS-2622 Remove ECR vulnerability scan check from development codepipeline #1024

mabe13 merged 1 commit into from
May 23, 2024

Conversation

@mabe13
Copy link
Collaborator

@mabe13 mabe13 commented May 23, 2024 •
edited
Loading

Task Branch Pull Request

https://nhsd-jira.digital.nhs.uk/browse/DS-2622

Description of Changes

Removes ECR vulnerability scan check from the development pipeline, missed from previous DS-2622 branch.

Reason from removal can be found in the ticket.

Type of change

Delete not appropriate

  • Bug fix (non-breaking change which fixes an issue)

Development Checklist

  • I have performed a self-review of my own code
  • Tests have added that prove my fix is effective or that my feature works (Integration tests)
  • I have updated Dependabot to include my changes (if applicable)

Code Reviewer Checklist

  • I can confirm the changes have been tested or approved by a tester

@mabe13 mabe13 changed the title DS-2622 Remove ECR vulnerability scan check from development codepipeline (missed, 2nd branch) DS-2622 Remove ECR vulnerability scan check from development codepipeline (missed 2nd branch) May 23, 2024
@mabe13 mabe13 changed the title DS-2622 Remove ECR vulnerability scan check from development codepipeline (missed 2nd branch) DS-2622 Remove missed ECR vulnerability scan check from development codepipeline 2nd branch May 23, 2024
@mabe13 mabe13 changed the title DS-2622 Remove missed ECR vulnerability scan check from development codepipeline 2nd branch DS-2622 Remove ECR vulnerability scan check from development codepipeline 2nd branch May 23, 2024
@mabe13 mabe13 changed the title DS-2622 Remove ECR vulnerability scan check from development codepipeline 2nd branch DS-2622 Remove ECR vulnerability scan check from development codepipeline May 23, 2024
@mabe13 mabe13 changed the title DS-2622 Remove ECR vulnerability scan check from development codepipeline DS-2622 Remove ECR vulnerability scan check from development codepipeline May 23, 2024
@mabe13 mabe13 requested a review from Tomdango May 23, 2024 13:47
@mabe13 mabe13 force-pushed the task/DS-2622_Remove_image_scan_check_from_develop_pipeline branch from a248842 to 0d4a2a7 Compare May 23, 2024 14:02
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mabe13 mabe13 merged commit 49b7efd into develop May 23, 2024
@mabe13 mabe13 deleted the task/DS-2622_Remove_image_scan_check_from_develop_pipeline branch May 23, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tomdango Tomdango Tomdango approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mabe13 @Tomdango