Skip to content

Conversation

@mabe13
Copy link
Collaborator

@mabe13 mabe13 commented May 23, 2024

Task Branch Pull Request

https://nhsd-jira.digital.nhs.uk/browse/DS-2622

Description of Changes

Removes last ECR vulnerability scan check from the development pipeline, missed from previous two DS-2622 branches. The last one only removed it from webhook based buildspec.

Reason from removal can be found in the ticket.

Type of change

Delete not appropriate

  • Bug fix (non-breaking change which fixes an issue)

Development Checklist

  • I have performed a self-review of my own code
  • Tests have added that prove my fix is effective or that my feature works (Integration tests)
  • I have updated Dependabot to include my changes (if applicable)

Code Reviewer Checklist

  • I can confirm the changes have been tested or approved by a tester

@mabe13 mabe13 force-pushed the task/DS-2622_Remove_last_image_scan_check branch from 01e3e9e to 0b1805a Compare May 23, 2024 15:13
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mabe13 mabe13 requested a review from Tomdango May 23, 2024 15:50
@mabe13 mabe13 enabled auto-merge (squash) May 23, 2024 15:58
@mabe13 mabe13 requested a review from vkjonnagadda May 24, 2024 09:54
Copy link
Contributor

@vkjonnagadda vkjonnagadda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go.

Copy link
Contributor

@vkjonnagadda vkjonnagadda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@mabe13 mabe13 merged commit b941f6f into develop May 24, 2024
@mabe13 mabe13 deleted the task/DS-2622_Remove_last_image_scan_check branch May 24, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants