Skip to content

DS-2829 Add missing HTTP security headers #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nsindhu26 merged 33 commits into from
Sep 26, 2024
Merged

DS-2829 Add missing HTTP security headers #1027

nsindhu26 merged 33 commits into from
Sep 26, 2024

Conversation

@nsindhu26
Copy link
Collaborator

@nsindhu26 nsindhu26 commented Sep 3, 2024 •
edited by mabe13
Loading

Task Branch Pull Request

https://nhsd-jira.digital.nhs.uk/browse/DS-2829

Description of Changes

Please include a summary of the change

Type of change

Delete not appropriate

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change which improves the structure of the code)

Development Checklist

  • I have performed a self-review of my own code
  • Tests have added that prove my fix is effective or that my feature works (Integration tests)
  • I have updated Dependabot to include my changes (if applicable)

Code Reviewer Checklist

  • I can confirm the changes have been tested or approved by a tester

Tomdango
Tomdango previously approved these changes Sep 3, 2024
View reviewed changes
@nsindhu26 nsindhu26 requested a review from a team as a code owner September 6, 2024 14:57
Sindhu and others added 27 commits September 18, 2024 15:34
@nsindhu26
DS-2829 Added security headers to all response types
fbd578b
@nsindhu26
Removing invalid headers
faa057b
@nsindhu26
Adding required headers
3ef4fcb
@nsindhu26
Escaping single quote
9ff62d2
@nsindhu26
Empty commit to trigger build
27c9043
@nsindhu26
Changed from X-Content-Type-Option to X-Content-Type-Options
999caa1
@nsindhu26
Empty commit to trigger build
d5aa45c
@nsindhu26
Removed X-Content-Type-Options to resolve bad request error
9ec918e
@nsindhu26
Adding both headers due to terraform issues
b22b0a4
@nsindhu26
Terraform deployed, removing invalid header
b42250f
@nsindhu26
Terraform failed, removing from integration response first
d05f78d
@nsindhu26
Terraform deployed, removing invalid header from method response
1946ea0
@nsindhu26
Empty commit to add ip address
0831b68
@nsindhu26
Testing catch all 4xx method response
b94afec
@nsindhu26
Adding specific method response for 403 status
53cbfb2
@nsindhu26
Empty commit to redo build
cc6ad89
@nsindhu26
Removed method response 403
dd6fc15
@nsindhu26
Removed integration response for 400
2de85e8
@nsindhu26
Removed method response for 400
76965e1
@nsindhu26
Added method response for 400
7c71e35
@nsindhu26
Removed api gateway response headers
f8c3ad8
@nsindhu26
Empty commit to redo build
1aecdb7
@nsindhu26
Empty commit to redo build
43aff22
@nsindhu26
Adding dependency to api gateway
ee373c2
@nsindhu26
Adding dependency to api gateway
01b648d
@nsindhu26
Adding dependency to api gateway
6dabccf
@nsindhu26
Adding dependency to api gateway
f98dbcc
@nsindhu26 nsindhu26 force-pushed the task/DS-2829_Http_security_headers branch from 5282289 to 4512ae8 Compare September 18, 2024 18:24
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mabe13
mabe13 reviewed Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@mabe13 mabe13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mabe13 mabe13 self-requested a review September 26, 2024 08:40
@nsindhu26 nsindhu26 merged commit f7d9fcb into develop Sep 26, 2024
@nsindhu26 nsindhu26 deleted the task/DS-2829_Http_security_headers branch September 26, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mabe13 mabe13 mabe13 approved these changes

@Tomdango Tomdango Tomdango left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nsindhu26 @Tomdango @mabe13