Skip to content

DS-2840 Sns encryption policy #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nsindhu26 merged 35 commits into from
Oct 8, 2024
Merged

DS-2840 Sns encryption policy #1032

nsindhu26 merged 35 commits into from
Oct 8, 2024

Conversation

@nsindhu26
Copy link
Collaborator

@nsindhu26 nsindhu26 commented Sep 25, 2024 •
edited by mabe13
Loading

Task Branch Pull Request

https://nhsd-jira.digital.nhs.uk/browse/DS-2840

Description of Changes

Please include a summary of the change

Type of change

Delete not appropriate

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change which improves the structure of the code)

Development Checklist

  • I have performed a self-review of my own code
  • Tests have added that prove my fix is effective or that my feature works (Integration tests)
  • I have updated Dependabot to include my changes (if applicable)

Code Reviewer Checklist

  • I can confirm the changes have been tested or approved by a tester

@nsindhu26
Empty commit to trigger build
7a4fa67
@nsindhu26
Empty commit to trigger build
a3b01ae
@nsindhu26
Removed X-Content-Type-Options to resolve bad request error
3ad0ece
@nsindhu26
Adding both headers due to terraform issues
1aaa055
@nsindhu26
Terraform deployed, removing invalid header
bcd7599
@nsindhu26
Terraform failed, removing from integration response first
f2f275e
@nsindhu26
Terraform deployed, removing invalid header from method response
3b5bdeb
@nsindhu26
Empty commit to add ip address
2eeb154
@nsindhu26
Testing catch all 4xx method response
893668b
@nsindhu26
Adding specific method response for 403 status
22ba7d5
@nsindhu26
Empty commit to redo build
37f3b35
@nsindhu26
Removed method response 403
c059585
@nsindhu26
Removed integration response for 400
b325e60
@nsindhu26
Removed method response for 400
9e59a2d
@nsindhu26
Added method response for 400
78b6596
@nsindhu26
Removed api gateway response headers
7e5016b
@nsindhu26
Empty commit to redo build
df16639
@nsindhu26
Empty commit to redo build
d6b815b
@nsindhu26
Adding dependency to api gateway
8b999dd
@nsindhu26
Adding dependency to api gateway
c759d73
@nsindhu26
Adding dependency to api gateway
f29e5d5
@nsindhu26
Adding dependency to api gateway
cda06da
@nsindhu26
Adding IT tests
f51ab17
@nsindhu26
Fixing python ruff checks
961ae21
@nsindhu26
Sns encryption weakness
ea5349b
@nsindhu26
Empty commit to trigger build
71c3431
@nsindhu26
Empty commit to trigger build
acc5c9c
@nsindhu26
Adding decrypt policy to slack messenger lambda
404b81c
@nsindhu26
Adding deny policy securetransport
24114c9
@nsindhu26
Correcting resource name in deny policy
55f2c38
@nsindhu26 nsindhu26 force-pushed the task/DS-2840_Sns_encryption_policy branch from 1779ff3 to 649a173 Compare September 27, 2024 08:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mabe13
mabe13 approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@mabe13 mabe13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mabe13 mabe13 changed the title Task/ds 2840 sns encryption policy DS-2840 sns encryption policy Oct 8, 2024
@mabe13 mabe13 changed the title DS-2840 sns encryption policy DS-2840 SNS encryption policy Oct 8, 2024
@mabe13 mabe13 changed the title DS-2840 SNS encryption policy DS-2840 Sns encryption policy Oct 8, 2024
@nsindhu26 nsindhu26 merged commit 11b94a1 into develop Oct 8, 2024
@nsindhu26 nsindhu26 deleted the task/DS-2840_Sns_encryption_policy branch October 8, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mabe13 mabe13 mabe13 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nsindhu26 @mabe13