Skip to content

Conversation

@mabe13
Copy link
Collaborator

@mabe13 mabe13 commented Dec 24, 2024

Task Branch Pull Request

https://nhsd-jira.digital.nhs.uk/browse/DS-3268

Description of Changes

This PR updates the lambda image builder for pipelines to use an arm based CodeBuild job. The 86x version stopped working due to an inability to install the docker xbuild plugin. The arm builder we use for task environments has not been affect by this issue. As such it makes sense to align the non-pipeline builder with the pipeline builder and have both CodeBuild jobs use an arm based container to build arm based images.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Development Checklist

  • I have performed a self-review of my own code
  • Tests have added that prove my fix is effective or that my feature works (Integration tests)
  • I have updated Dependabot to include my changes (if applicable)

Code Reviewer Checklist

  • I can confirm the changes have been tested or approved by a tester

@sonarqubecloud
Copy link

@mabe13 mabe13 requested a review from nsindhu26 December 24, 2024 15:02
@mabe13 mabe13 merged commit b91710c into develop Dec 24, 2024
22 of 25 checks passed
@mabe13 mabe13 deleted the task/DS-3268_Release_pipeline_xbuild_bug branch December 24, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants