Skip to content

Conversation

@mik3ola
Copy link
Contributor

@mik3ola mik3ola commented Aug 10, 2022

Warning

Please don't modify this description yet it will be populated once you create the pull request.

@mik3ola mik3ola requested a review from a team as a code owner August 10, 2022 22:33
@JackPlowman JackPlowman changed the base branch from develop to hotfix/DI-544_Spec_open_times_bug August 11, 2022 08:23
Copy link
Contributor

@JackPlowman JackPlowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good, just interested in why a couple of bit have been changed as they might break other tests

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mik3ola mik3ola requested a review from JackPlowman August 11, 2022 16:54
@mik3ola mik3ola merged commit 4721a75 into hotfix/DI-544_Spec_open_times_bug Aug 11, 2022
@mik3ola mik3ola deleted the task/DI-547_Spec_opening_times_test branch August 11, 2022 17:06
mabe13 pushed a commit that referenced this pull request Aug 17, 2022
* Fixed hash function for OpenPeriod and added unit tests

* DI-547 Specified opening time bug fix test (#475)

* Spec opening times bug fix test

* Update step def file

Co-authored-by: Michael Olaw <67810234+mik3ola@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants