fix: DTOSS-8363 App Service certificate bindings #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickmoore-nc
changed the title
patrickmoore-nc
changed the title
patrickmoore-nc
force-pushed
the
fix/debug-app-service-cert
branch
from
8a6cca6 to
02c111c
Compare
josielsouzanordcloud
approved these changes
May 8, 2025
Contributor
josielsouzanordcloud
left a comment
josielsouzanordcloud
left a comment
There was a problem hiding this comment.
Peer review code
This was referenced May 8, 2025
patrickmoore-nc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change automates App Service certificate bindings, including workarounds for non-working Key Vault Certificate references to elliptic curve certificates. The workaround is that certificates are also stored as pfx blobs in Key Vault Secret objects, which App Services may import at build time without issue. The downside is they will not dynamically update if the Key Vault certificate is renewed. The Terraform will need to be re-deployed in that event.
Linked to:
Context
Workaround was necessary after it was established that there was a technical issue with App Service elliptic curve cryptography support via Key Vault (Azure Support Request 2505010050001340).
Testing
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.