Skip to content

Conversation

@mrlockstar
Copy link
Contributor

@mrlockstar mrlockstar commented May 27, 2025

Description

We must deploy private end points into the module because the Service bus is not publically accessible. This module has been successfully tested in the Analytics Data Pipeline project.

Please note the example notes on how to do it have also been updated.

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@mrlockstar mrlockstar force-pushed the feat/DTOSS-9003-Deploy-service-bus-into-the-hub-vnet branch from adda86c to 65bb31d Compare May 27, 2025 13:44
Copy link
Contributor

@MacMur85 MacMur85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mrlockstar mrlockstar added this pull request to the merge queue May 27, 2025
Merged via the queue into main with commit 08f0db8 May 27, 2025
21 checks passed
@mrlockstar mrlockstar deleted the feat/DTOSS-9003-Deploy-service-bus-into-the-hub-vnet branch May 27, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants