Skip to content

feature/eli-626-update-examples-and-app-restricted#333

Merged
jhadfield-NHS merged 3 commits intomainfrom
feature/eli-626-update-examples-and-app-restricted
Feb 3, 2026
Merged

feature/eli-626-update-examples-and-app-restricted#333
jhadfield-NHS merged 3 commits intomainfrom
feature/eli-626-update-examples-and-app-restricted

Conversation

@jhadfield-NHS
Copy link
Copy Markdown
Contributor

Description

Included application restricted as supported and removed this is not currently support text

Example RSV 5000000025 - Added DateOfLastVaccination and corrected dates

Example RSV 5000000026 - Corrected DateOfLastVaccination to align with ruleText

Example COVID 5000000106 - Corrected DateOfLastVaccination to align with ruleText

Example COVID 5000000110 - Added DateOfLastVaccination, amended ruleText and corrected DateOfNextEarliestVaccination

Context

Additional scenarios and corrections noted during QA

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Included application restricted as supported and removed this is not currently support text

Example RSV 5000000025 - Added DateOfLastVaccination and corrected dates

Example RSV 5000000026 - Corrected DateOfLastVaccination to align with ruleText

Example COVID 5000000106 - Corrected DateOfLastVaccination to align with ruleText

Example COVID 5000000110 - Added DateOfLastVaccination, amended ruleText and corrected DateOfNextEarliestVaccination
Correct error in supplied example (25)
@jhadfield-NHS jhadfield-NHS changed the title Update eligibility-signposting-api.yaml feature/eli-626-update-examples-and-app-restricted Feb 2, 2026
Copy link
Copy Markdown

@ayeshalshukri1-nhs ayeshalshukri1-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link
Copy Markdown

@ayeshalshukri1-nhs ayeshalshukri1-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@jhadfield-NHS jhadfield-NHS merged commit 16102e4 into main Feb 3, 2026
8 checks passed
@jhadfield-NHS jhadfield-NHS deleted the feature/eli-626-update-examples-and-app-restricted branch February 5, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants