Skip to content

updated github actions policy#621

Merged
oneeb-nhs merged 2 commits intomainfrom
ELI-704/updated-github-actions-permissions
Mar 30, 2026
Merged

updated github actions policy#621
oneeb-nhs merged 2 commits intomainfrom
ELI-704/updated-github-actions-permissions

Conversation

@oneeb-nhs
Copy link
Copy Markdown
Contributor

Description

Updated github actions policy to allow creation of cloudwatch bucket, log groups and IAM role

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

"cloudwatch:GetMetricWidgetImage",

# CloudTrail - trail management
"cloudtrail:AddTags",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cloudtrail:* can be used here, as it's a permissions boundary (so doesn't grant wide-reaching permissions). We use :* as the policy is reaching the point of being too big!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated as suggested

eddalmond1
eddalmond1 previously approved these changes Mar 30, 2026
@oneeb-nhs oneeb-nhs merged commit dbb0ec3 into main Mar 30, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants