Chore: [AEA-0000] - set permissions for tag workflow#1011
Merged
anthony-nhs merged 1 commit intomainfrom Mar 18, 2026
Merged
Conversation
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-0000 |
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions release workflow to set explicit permissions for the tag_release reusable workflow job (likely to enable OIDC token issuance), and adjusts .gitallowed to allow the new YAML string.
Changes:
- Add job-level
permissionstotag_releasein.github/workflows/release.yml. - Add an allow-list entry for
id-token: 'write'in.gitallowed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/release.yml |
Adds explicit job permissions for the tag-release reusable workflow job. |
.gitallowed |
Allows the newly introduced id-token: 'write' text pattern. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| needs: [quality_checks, get_commit_id, get_config_values] | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/tag-release-devcontainer.yml@update_jira | ||
| permissions: | ||
| id-token: 'write' |
| .*nhsd-rules-deny.txt.* | ||
| .*\.venv.* | ||
| .*node_modules.* | ||
| id-token: 'write' |
| needs: [quality_checks, get_commit_id, get_config_values] | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/tag-release-devcontainer.yml@update_jira | ||
| permissions: | ||
| id-token: 'write' |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details