Chore: [AEA-0000] - handle stack does not exist in check destructive changes#710
Merged
anthony-nhs merged 1 commit intomainfrom Apr 27, 2026
Merged
Chore: [AEA-0000] - handle stack does not exist in check destructive changes#710anthony-nhs merged 1 commit intomainfrom
anthony-nhs merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates destructive change-set checking to gracefully handle the case where the target CloudFormation stack no longer exists, avoiding an error in that scenario.
Changes:
- Add a pre-flight
DescribeStackscheck incheckDestructiveChangeSetand skip processing when the stack is missing. - Update Vitest mocks to include
DescribeStacksCommandand adjust expectations for the additional SDK call. - Add a new test case asserting the “stack does not exist” path logs and exits cleanly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/cdkConstructs/src/changesets/checkDestructiveChanges.ts | Adds a stack-existence check (via DescribeStacks) and early-return behavior when the stack is missing. |
| packages/cdkConstructs/tests/changesets/checkDestructiveChanges.test.ts | Extends AWS SDK mocks and updates/adds tests to cover the new stack-missing behavior. |
|
MatthewPopat-NHS
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details