Merged
Conversation
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-0000 |
There was a problem hiding this comment.
Pull request overview
This PR fixes the CI workflow configuration so the tag_release reusable workflow receives an appropriate branch_name value when the workflow runs on push to main.
Changes:
- Update
branch_namein.github/workflows/ci.ymlfrom a PR-only context expression to amainvalue for push-based runs.
| dry_run: true | ||
| pinned_image: ${{ needs.get_config_values.outputs.pinned_image }} | ||
| branch_name: ${{ github.event.pull_request.head.ref }} | ||
| branch_name: main |
There was a problem hiding this comment.
branch_name is hardcoded to main, which can drift if the workflow’s trigger branches change or if the default branch is renamed. Consider deriving it from the event context (e.g., github.ref_name) so the value always matches the branch the workflow ran on.
Suggested change
| branch_name: main | |
| branch_name: ${{ github.ref_name }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details