Fix: [AEA-5081] - new header branch #1605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-5081 |
jonathanwelch1-nhs
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
jonathanwelch1-nhs
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
jonathanwelch1-nhs
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
jonathanwelch1-nhs
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
…-5081-latest-header �Please enter a commit message to explain why this merge is necessary,
jonathanwelch1-nhs
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
Orkastrated
reviewed
Dec 18, 2025
| data-testid="eps-card" | ||
| className="nhsuk-card nhsuk-card--primary nhsuk-u-margin-bottom-4" | ||
| tabIndex={0} | ||
| onKeyDown={(e) => { |
Contributor
There was a problem hiding this comment.
You might want to break this function out of the jsx just to make it a little easier to read
Orkastrated
reviewed
Dec 18, 2025
| useEffect(() => { | ||
| const isMobile = window.innerWidth <= 900 | ||
| if (isMobile) { | ||
| const timer = setTimeout(() => { |
Contributor
There was a problem hiding this comment.
whats the purpose of the sleep? is there a reason why you cant immediately resize?
|
jonathanwelch1-nhs
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
Orkastrated
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://nhsd-jira.digital.nhs.uk/browse/AEA-5081
https://nhsd-jira.digital.nhs.uk/browse/AEA-5338
Details
implemented the new header from NCRS.
had to utilise their 'double tap' logic to get it to work on mobile view.