Fix: [AEA-0000] - Defines ValidationError to remove circular dependency#100
Merged
JackSpagnoliNHS merged 3 commits intomainfrom Mar 24, 2026
Merged
Fix: [AEA-0000] - Defines ValidationError to remove circular dependency#100JackSpagnoliNHS merged 3 commits intomainfrom
JackSpagnoliNHS merged 3 commits intomainfrom
Conversation
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-0000 |
There was a problem hiding this comment.
Pull request overview
Defines a local ValidationError in eps_spine_shared to eliminate a circular dependency caused by importing Spine’s validation error type when this package is used within Spine.
Changes:
- Removed import of
spinecore.prescriptions.common.local_validator.ValidationError. - Added a locally defined
ValidationErrorexception for use by Spine wrappers.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
originalphil
approved these changes
Mar 24, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Defines ValidationError to remove circular dependency when importing to spine