Skip to content

Chore: [AEA-0000] - use gitleaks for secret scanning #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthony-nhs merged 1 commit into from
Apr 17, 2026
Merged

Chore: [AEA-0000] - use gitleaks for secret scanning #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions .gitallowed
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,13 @@ repos:
pass_filenames: false
always_run: true

- id: git-secrets
name: Git Secrets
description: git-secrets scans commits, commit messages, and --no-ff merges to prevent adding secrets into your git repositories.
- id: gitleaks
name: Git Leaks
description: gitleaks scans commits, commit messages, and --no-ff merges to prevent adding secrets into your git repositories.
entry: bash
args:
- -c
- 'git-secrets --pre_commit_hook'
- "gitleaks git --pre-commit --redact --staged --verbose"
Comment on lines +50 to +55
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hook description claims it scans commit messages and --no-ff merges, but this pre-commit config only runs at the pre-commit stage and the command uses --staged. Please update the description (or stages/command) so it accurately reflects what is actually scanned.

Copilot uses AI. Check for mistakes.
language: system
Comment on lines +49 to 56
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hook uses language: system and relies on a locally installed gitleaks with an unpinned CLI interface. To avoid contributors/CI breaking when gitleaks isn't installed or its subcommands/flags differ by version, prefer using the official pre-commit hook repo (pinning rev) or otherwise ensuring installation/version pinning in the devcontainer/tooling.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gitleaks hook is missing pass_filenames: false and always_run: true. As written, pre-commit will pass filenames to bash -c (unneeded/large argv) and the hook may be skipped on empty commits; secret scanning hooks typically should run regardless of which files changed.

Suggested change
language: system
language: system
pass_filenames: false
always_run: true

Copilot uses AI. Check for mistakes.

- id: python-pre-commit
Expand Down