Chore: [AEA-0000] - move to common dev container#98
Merged
anthony-nhs merged 10 commits intomainfrom Mar 20, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the repo’s local development and CI setup to the shared “common devcontainer” approach, removing in-repo asdf/tool-version management and switching CI workflows to the devcontainer-based common workflows.
Changes:
- Update GitHub workflows to use
get-repo-config+ devcontainer-based quality checks/tagging workflows. - Replace the local devcontainer build with the shared
ghcr.io/nhsdigital/eps-devcontainers/*base image and adjust git-secrets integration. - Remove asdf/tool-version files and local license-check automation.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
scripts/check_python_licenses.sh |
Removed local pip-licenses script used for license compatibility checks. |
Makefile |
Removes check-licenses target from make commands. |
.tool-versions.asdf |
Removed asdf version pin file. |
.tool-versions |
Removed tool pin file (python/poetry/etc.). |
.pre-commit-config.yaml |
Runs git-secrets directly rather than via Docker. |
.github/workflows/release.yaml |
Migrates release pipeline to devcontainer-based common workflows and containerized build. |
.github/workflows/pull_request.yaml |
Migrates PR pipeline to devcontainer-based common workflows. |
.github/workflows/ci.yaml |
Migrates CI pipeline to devcontainer-based common workflows. |
.github/actions/install_dependencies/action.yaml |
Removes composite action that installed dependencies via asdf. |
.github/actions/get_asdf_version/action.yaml |
Removes composite action that read asdf version from .tool-versions.asdf. |
.devcontainer/devcontainer.json |
Updates devcontainer config to build from shared image args and change git-secrets setup command. |
.devcontainer/Dockerfile |
Switches to shared devcontainer base image and attempts docker group/GID alignment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| with: | ||
| asdf_version: ${{ needs.get_asdf_version.outputs.version }} | ||
|
|
||
| uses: actions/checkout@v6 |
Comment on lines
6
to
11
| build: | ||
| poetry build | ||
|
|
||
| check-licenses: | ||
| scripts/check_python_licenses.sh | ||
|
|
||
| clean: | ||
| rm -rf dist | ||
| rm -rf htmlcov |
Comment on lines
6
to
11
| build: | ||
| poetry build | ||
|
|
||
| check-licenses: | ||
| scripts/check_python_licenses.sh | ||
|
|
||
| clean: | ||
| rm -rf dist | ||
| rm -rf htmlcov |
Comment on lines
6
to
11
| build: | ||
| poetry build | ||
|
|
||
| check-licenses: | ||
| scripts/check_python_licenses.sh | ||
|
|
||
| clean: | ||
| rm -rf dist | ||
| rm -rf htmlcov |
Comment on lines
21
to
28
| - id: git-secrets | ||
| name: Git Secrets | ||
| description: git-secrets scans commits, commit messages, and --no-ff merges to prevent adding secrets into your git repositories. | ||
| entry: bash | ||
| args: | ||
| - -c | ||
| - 'docker run -v "$LOCAL_WORKSPACE_FOLDER:/src" git-secrets --pre_commit_hook' | ||
| - 'git-secrets --pre_commit_hook' | ||
| language: system |
Comment on lines
+5
to
+10
| USER root | ||
| # specify DOCKER_GID to force container docker group id to match host | ||
| RUN if [ -n "${DOCKER_GID}" ]; then \ | ||
| if ! getent group docker; then \ | ||
| groupadd -g ${DOCKER_GID} docker; \ | ||
| else \ |
Comment on lines
+9
to
+11
| "IMAGE_VERSION": "v1.1.3", | ||
| "USER_UID": "${localEnv:USER_ID:}", | ||
| "USER_GID": "${localEnv:GROUP_ID:}" |
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-0000 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details