[HOTE-559] feat: View negative results page

[cptiv2020]

Description

https://nhsd-jira.digital.nhs.uk/browse/HOTE-559

re-opened with new branch naming: #149

Context

Type of changes

• Refactoring (non-breaking change)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would change existing functionality)
• Bug fix (non-breaking change which fixes an issue)

Checklist

• I am familiar with the contributing guidelines
• I have followed the code style of the project
• I have added tests to cover my changes
• I have updated the documentation accordingly
• This PR is a result of pair or mob programming

---

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

• I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

[github-actions]

Lambdas Coverage Report

Lines	Statements	Branches	Functions
	91.3% (21/23)	100% (0/0)	87.5% (7/8)

[github-actions]

UI Coverage Report

Lines	Statements	Branches	Functions
	92.96% (3225/3469)	86.96% (327/376)	78.72% (111/141)

[Copilot]

Pull request overview

Adds support for viewing a negative HIV self-test result page in the UI, backed by a new results API/service layer, plus supporting content and end-to-end accessibility coverage.

Changes:

• Adds a new /orders/:orderId/results route and UI components for the negative result view (with redirects back to tracking when results aren’t available/eligible).
• Introduces new UI query/service utilities for fetching results and centralises GUID validation.
• Updates lambda DB queries and local CORS config to support results retrieval, plus adds unit/UI/a11y tests.

Reviewed changes

Copilot reviewed 48 out of 51 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
ui/src/routes/TestResultsPage.tsx	New results route logic (order/result gating + redirect).
ui/src/routes/OrderTrackingPage.tsx	Switches to shared GUID util + order status query hook + page content hook.
ui/src/lib/utils/guid.ts	Extracted GUID/UUID validation helper.
ui/src/lib/utils/fhir-utils.ts	Adds FHIR Observation “normal” interpretation helper.
ui/src/lib/utils/fhir-constants.ts	Adds constants for Observation interpretation system/code.
ui/src/lib/services/test-results-service.ts	New UI service to call /results and map Observation → TestResult.
ui/src/lib/services/supplier-service.ts	Centralised supplier link metadata lookup.
ui/src/lib/queries/test-results-query.ts	React Query hook for test results.
ui/src/lib/queries/query-keys.ts	Shared query key names for React Query.
ui/src/lib/queries/order-status-query.ts	React Query hook wrapper for order status.
ui/src/lib/models/test-result.ts	New UI model for test results.
ui/src/lib/models/route-paths.ts	Adds TestResultsPage route path.
ui/src/components/test-results/NegativeTestResult.tsx	Negative result page content component.
ui/src/components/test-results/MoreOptionsAndInformation.tsx	Supplementary “more options” section component.
ui/src/components/test-results/MedicalAbbreviationsHelp.tsx	Help link section component.
ui/src/components/order-status/statuses/ReadyStatus.tsx	Replaces placeholder link with router Link to results page.
ui/src/components/order-status/statuses/HelpLinks.tsx	Uses supplier service for contact link instead of #.
ui/src/components/order-status/OrderStatusHeader.tsx	Allows caller-provided heading text.
ui/src/components/order-status/OrderStatusContent.tsx	Passes orderId into ReadyStatus.
ui/src/components/order-status/OrderStatus.tsx	Passes fixed heading string to OrderStatusHeader.
ui/src/app.tsx	Registers new results route under guarded app routes.
ui/src/tests/routes/TestResultsPage.test.tsx	Unit tests for results route behaviour and redirects.
ui/src/tests/lib/utils/fhir-utils.test.ts	Unit tests for FHIR utility helpers.
ui/src/tests/lib/services/test-results-service.test.ts	Unit tests for results service request/response mapping.
ui/src/tests/lib/services/supplier-service.test.ts	Unit tests for supplier link lookup.
ui/src/tests/lib/services/la-lookup-service.test.ts	Minor test import/style adjustments.
ui/src/tests/components/order-status/OrderStatusHeader.test.tsx	Updates tests for new heading prop.
ui/src/tests/components/NegativeTestResult.test.tsx	Unit tests for negative result component rendering.
ui/src/tests/components/MoreOptionsAndInformation.test.tsx	Unit tests for more-options component.
ui/src/tests/components/MedicalAbbreviationsHelp.test.tsx	Unit tests for abbreviations help component.
ui/package.json	Bumps @types/node patch version.
ui/package-lock.json	Lockfile updates for @types/node + dependencies.
ui/hooks/useContent.ts	Adds test-results page content typing + overload.
ui/content/schema.ts	Adds TestResultsContent type (but currently has duplicate interface declarations).
ui/content/index.ts	Exports TestResultsContent type.
ui/content/content.json	Adds test-results page content (contains a title typo).
ui/content/ContentValidator.ts	Requires test-results page content key.
tests/tests/accessibility/NegativeResultsTest.spec.ts	New Playwright accessibility spec for negative results page.
tests/page-objects/NegativeResultPage.ts	New page object for results navigation/assertions.
tests/db/TestResultDbClient.ts	Import tidy-up.
tests/db/TestOrderDbClient.ts	Import order tidy-up.
tests/api/clients/HIVResultsApiResource.ts	Import/order formatting tidy-up.
package-lock.json	Root lockfile updates.
local-environment/infra/main.tf	Adds CORS allowed headers including X-Correlation-ID.
lambdas/src/lib/db/test-result-db-client.ts	Refactors ctor + changes SQL schema qualifiers (but JOIN condition is incorrect).
lambdas/src/lib/db/test-result-db-client.test.ts	Updates expected SQL (currently matches the incorrect JOIN).
lambdas/src/lib/db/order-db-client.ts	Refactors ctor + changes SQL schema qualifiers.
lambdas/src/lib/db/order-db-client.test.ts	Updates expected SQL.
lambdas/src/get-results-lambda/init.test.ts	Import reorder/cleanup.
lambdas/src/get-order-lambda/init.test.ts	Import reorder/cleanup.
.gitignore	Stops ignoring ui/src/components/test-results/ folder.

Files not reviewed (1)

• ui/package-lock.json: Language not supported

Comments suppressed due to low confidence (1)

ui/content/schema.ts:364

• OrderTrackingContent removal introduced duplicate type declarations later in this file: PrivacyPolicySubsection, PrivacyPolicySection, and HomeTestPrivacyPolicyContent are each declared twice, which will cause a TypeScript "Duplicate identifier" compile error. Remove the duplicate block and keep a single set of these interfaces.

export interface PrivacyPolicySubsection {
  heading?: string;
  paragraphs?: string[];
  list?: string[];
}

export interface PrivacyPolicySection {
  id: string;
  heading: string;
  paragraphs: string[];
  subsections?: PrivacyPolicySubsection[];
}

export interface HomeTestPrivacyPolicyContent {
  title: string;
  introduction: string[];
  sections: PrivacyPolicySection[];
}

export interface PrivacyPolicySubsection {
  heading?: string;
  paragraphs?: string[];
  list?: string[];
}

export interface PrivacyPolicySection {
  id: string;
  heading: string;
  paragraphs: string[];
  subsections?: PrivacyPolicySubsection[];
}

export interface HomeTestPrivacyPolicyContent {
  title: string;
  introduction: string[];
  sections: PrivacyPolicySection[];
}

[Copilot]

Pull request overview

Copilot reviewed 49 out of 52 changed files in this pull request and generated no new comments.

Files not reviewed (1)

• ui/package-lock.json: Language not supported

Comments suppressed due to low confidence (2)

ui/content/schema.ts:364

• PrivacyPolicySubsection, PrivacyPolicySection, and HomeTestPrivacyPolicyContent are declared twice in this file (around lines 328–364), which will cause TypeScript duplicate identifier errors. Remove the duplicate set of interface declarations and keep a single canonical definition.

export interface PrivacyPolicySubsection {
  heading?: string;
  paragraphs?: string[];
  list?: string[];
}

export interface PrivacyPolicySection {
  id: string;
  heading: string;
  paragraphs: string[];
  subsections?: PrivacyPolicySubsection[];
}

export interface HomeTestPrivacyPolicyContent {
  title: string;
  introduction: string[];
  sections: PrivacyPolicySection[];
}

export interface PrivacyPolicySubsection {
  heading?: string;
  paragraphs?: string[];
  list?: string[];
}

export interface PrivacyPolicySection {
  id: string;
  heading: string;
  paragraphs: string[];
  subsections?: PrivacyPolicySubsection[];
}

export interface HomeTestPrivacyPolicyContent {
  title: string;
  introduction: string[];
  sections: PrivacyPolicySection[];
}

ui/src/routes/OrderTrackingPage.tsx:28

• useOrderStatusQuery returns data as undefined while the query is pending, so if (!order) will render the “order not found” error during loading (and also hides query errors). Destructure and handle isPending/error (e.g., return a loading state or null while pending, and throw/render an error for error) before treating order === null as the not-found case.

[Copilot]

Pull request overview

Copilot reviewed 49 out of 51 changed files in this pull request and generated 6 comments.

Files not reviewed (1)

• ui/package-lock.json: Language not supported

Comments suppressed due to low confidence (1)

ui/src/routes/OrderTrackingPage.tsx:28

• useOrderStatusQuery returns data as undefined while the request is pending, but this component treats any falsy order as “not found”. That means the “We could not find this order.” alert will render during the initial load (and also for network/errors), which is misleading and can cause a visible flash before the real order renders. Handle isPending/isLoading (and error) from the query separately (e.g., return null/spinner while pending, and throw/show a distinct error state when error is set).