Skip to content

[HOTE-838] feat: Schema verification#290

Merged
cptiv2020 merged 2 commits intomainfrom
feature/hote-838/schema-testing
Mar 30, 2026
Merged

[HOTE-838] feat: Schema verification#290
cptiv2020 merged 2 commits intomainfrom
feature/hote-838/schema-testing

Conversation

@cptiv2020
Copy link
Copy Markdown
Contributor

Description

https://nhsd-jira.digital.nhs.uk/browse/HOTE-838

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Copilot AI review requested due to automatic review settings March 27, 2026 08:57
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 27, 2026

Lambdas Coverage Report

Lines Statements Branches Functions
Coverage: 96%
97% (1164/1200) 89.9% (365/406) 94.14% (177/188)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 27, 2026

UI Coverage Report

Lines Statements Branches Functions
Coverage: 95%
95.5% (5583/5846) 87.28% (652/747) 87.5% (203/232)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a migration “schema verification” step to the local database migration flow, ensuring Goose migrations are validated before applying them, and updates the tooling image to a newer Go/Goose version.

Changes:

  • Add goose validate step to the local DB migration script (before goose up).
  • Bump the Goose builder image Go version and the installed Goose CLI version.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
local-environment/scripts/database/db-migrate.sh Adds an explicit Goose validation step and improves step output formatting.
local-environment/scripts/database/Dockerfile Updates the Go base image and Goose CLI version used to build the migration container.

@sonarqubecloud
Copy link
Copy Markdown

@cptiv2020 cptiv2020 merged commit 8f0408f into main Mar 30, 2026
11 checks passed
@cptiv2020 cptiv2020 deleted the feature/hote-838/schema-testing branch March 30, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants