Skip to content

[HOTE-1020] feat: [Database] Remove unused column from status table#301

Merged
cptiv2020 merged 7 commits intomainfrom
feature/hote-1020/remove-unused-column
Mar 31, 2026
Merged

[HOTE-1020] feat: [Database] Remove unused column from status table#301
cptiv2020 merged 7 commits intomainfrom
feature/hote-1020/remove-unused-column

Conversation

@cptiv2020
Copy link
Copy Markdown
Contributor

@cptiv2020 cptiv2020 commented Mar 31, 2026

Description

https://nhsd-jira.digital.nhs.uk/browse/HOTE-1020

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Copilot AI review requested due to automatic review settings March 31, 2026 08:15
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 31, 2026

Lambdas Coverage Report

Lines Statements Branches Functions
Coverage: 97%
97.79% (1239/1267) 91.35% (370/405) 95.04% (192/202)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 31, 2026

UI Coverage Report

Lines Statements Branches Functions
Coverage: 95%
95.5% (5583/5846) 87.28% (652/747) 87.5% (203/232)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new Goose migration to remove the order_reference column from the order_status table in the database/ package.

Changes:

  • Add migration 000006 that drops order_status.order_reference on Up.
  • Provide Down migration to re-add order_reference as a bigint.

Comment thread database/migrations/000006_remove_order_reference_from_order_status.sql Outdated
Comment thread database/migrations/000006_remove_order_reference_from_order_status.sql Outdated
Copilot AI review requested due to automatic review settings March 31, 2026 09:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

database/schema_diagram.puml:67

  • result_status.result_id is shown as uuid in the schema diagram, but the actual table defines it as a bigint identity (migration 000001), so the diagram is incorrect; update the type to match the DB schema.
entity "result_status" as result_status {
  **result_id : uuid**
  *order_uid : uuid*
  *status : varchar(50)*
  created_at : timestamp
  correlation_id : uuid
}

Comment thread database/schema_diagram.puml
Copilot AI review requested due to automatic review settings March 31, 2026 11:09
@cptiv2020 cptiv2020 enabled auto-merge (squash) March 31, 2026 11:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@cptiv2020 cptiv2020 disabled auto-merge March 31, 2026 11:18
@sonarqubecloud
Copy link
Copy Markdown

Comment thread database/migrations/000006_remove_order_reference_from_order_status.sql Outdated
@cptiv2020 cptiv2020 merged commit e39a736 into main Mar 31, 2026
11 checks passed
@cptiv2020 cptiv2020 deleted the feature/hote-1020/remove-unused-column branch March 31, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants