Skip to content

[HOTE-1013] feat: Create table for Notify messages auditing#302

Merged
cptiv2020 merged 7 commits intomainfrom
feature/hote-1013/notify-audit-table
Apr 1, 2026
Merged

[HOTE-1013] feat: Create table for Notify messages auditing#302
cptiv2020 merged 7 commits intomainfrom
feature/hote-1013/notify-audit-table

Conversation

@cptiv2020
Copy link
Copy Markdown
Contributor

@cptiv2020 cptiv2020 commented Mar 31, 2026

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 31, 2026

Lambdas Coverage Report

Lines Statements Branches Functions
Coverage: 97%
97.8% (1245/1273) 91.4% (372/407) 95.07% (193/203)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 31, 2026

UI Coverage Report

Lines Statements Branches Functions
Coverage: 95%
95.5% (5583/5846) 87.28% (652/747) 87.5% (203/232)

Comment thread database/schema_diagram.puml
Base automatically changed from feature/hote-1020/remove-unused-column to main March 31, 2026 11:29
…ote-1013/notify-audit-table

# Conflicts:
#	database/migrations/000006_remove_order_reference_from_order_status.sql
Copilot AI review requested due to automatic review settings March 31, 2026 11:44
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new database table to audit GOV.UK Notify message events, and reflects it in the database schema diagram.

Changes:

  • Introduces a new notification_audit table (with uniqueness constraint and index) via Goose migration.
  • Updates schema_diagram.puml to include the new table.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
database/schema_diagram.puml Adds notification_audit entity to the ER diagram.
database/migrations/000007_add_notification_audit_table.sql Creates notification_audit table, uniqueness constraint, and index (plus down migration).

Comment thread database/schema_diagram.puml Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 31, 2026 11:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread database/migrations/000007_add_notification_audit_table.sql Outdated
@sonarqubecloud
Copy link
Copy Markdown

@cptiv2020 cptiv2020 merged commit 9cfd59d into main Apr 1, 2026
13 checks passed
@cptiv2020 cptiv2020 deleted the feature/hote-1013/notify-audit-table branch April 1, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants