Skip to content

[HOTE-840] feat: Add esbuild to production NODE_ENV#313

Merged
mikeeq merged 1 commit intomainfrom
feature/hote-840/Enable-Network-firewall
Apr 2, 2026
Merged

[HOTE-840] feat: Add esbuild to production NODE_ENV#313
mikeeq merged 1 commit intomainfrom
feature/hote-840/Enable-Network-firewall

Conversation

@mikeeq
Copy link
Copy Markdown
Collaborator

@mikeeq mikeeq commented Apr 2, 2026

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Copilot AI review requested due to automatic review settings April 2, 2026 08:54
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2026

Lambdas Coverage Report

Lines Statements Branches Functions
Coverage: 97%
97.88% (1299/1327) 91.84% (394/429) 95.32% (204/214)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2026

UI Coverage Report

Lines Statements Branches Functions
Coverage: 95%
95.5% (5583/5846) 87.28% (652/747) 87.5% (203/232)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the lambdas/ package dependencies so the esbuild build tool is installed even when installing with production-only dependencies (e.g., NODE_ENV=production / --omit=dev), ensuring lambda build/packaging scripts can run in production-like environments.

Changes:

  • Move esbuild@0.27.4 from devDependencies to dependencies in lambdas/package.json.
  • Regenerate lambdas/package-lock.json to reflect esbuild as a production dependency (and its optional platform packages).
  • Lockfile also updates a transitive lodash entry.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
lambdas/package.json Promotes esbuild to a production dependency so build scripts work with production installs.
lambdas/package-lock.json Updates lockfile for the dependency move (plus includes an additional transitive lodash change).
Files not reviewed (1)
  • lambdas/package-lock.json: Language not supported

Comment thread lambdas/package-lock.json
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 2, 2026

@mikeeq mikeeq merged commit 3c060c8 into main Apr 2, 2026
15 checks passed
@mikeeq mikeeq deleted the feature/hote-840/Enable-Network-firewall branch April 2, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants