Skip to content

VED-1043: Tidy up Grafana related code#1193

Merged
edhall-nhs merged 3 commits intomasterfrom
feature/VED-1043-remove-grafana-code
Feb 10, 2026
Merged

VED-1043: Tidy up Grafana related code#1193
edhall-nhs merged 3 commits intomasterfrom
feature/VED-1043-remove-grafana-code

Conversation

@edhall-nhs
Copy link
Contributor

@edhall-nhs edhall-nhs commented Feb 10, 2026

Summary

  • Routine Change

Remove grafana code, dependabot, README references and sonar config.

Manually created infrastructure will be manually decommissioned.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
  • I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-1043

@edhall-nhs edhall-nhs temporarily deployed to internal-dev-sandbox February 10, 2026 11:03 — with GitHub Actions Inactive
@edhall-nhs edhall-nhs temporarily deployed to internal-dev-sandbox February 10, 2026 11:05 — with GitHub Actions Inactive
@edhall-nhs edhall-nhs temporarily deployed to internal-dev-sandbox February 10, 2026 11:06 — with GitHub Actions Inactive
JamesW1-NHS
JamesW1-NHS reviewed Feb 10, 2026
View reviewed changes
Copy link
Contributor

@JamesW1-NHS JamesW1-NHS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are references to grafana in some of the poetry.lock files as well - do we need to regenerate those?

@edhall-nhs
Copy link
Contributor Author

edhall-nhs commented Feb 10, 2026

There are references to grafana in some of the poetry.lock files as well - do we need to regenerate those?

I spotted those. Looking at the history, they were there from a while back so I left them in. There were other similar things that we've never used so I thought it's probably best to leave it and let poetry handle our dependencies

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 10, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@edhall-nhs edhall-nhs temporarily deployed to internal-dev-sandbox February 10, 2026 11:32 — with GitHub Actions Inactive
@edhall-nhs edhall-nhs temporarily deployed to internal-dev-sandbox February 10, 2026 11:36 — with GitHub Actions Inactive
@edhall-nhs edhall-nhs temporarily deployed to internal-dev-sandbox February 10, 2026 11:36 — with GitHub Actions Inactive
@edhall-nhs edhall-nhs changed the title VED1043: Tidy up Grafana related code VED-1043: Tidy up Grafana related code Feb 10, 2026
@edhall-nhs edhall-nhs merged commit e59d97c into master Feb 10, 2026
17 checks passed
@edhall-nhs edhall-nhs deleted the feature/VED-1043-remove-grafana-code branch February 10, 2026 13:57
dlzhry2nhs added a commit that referenced this pull request Feb 17, 2026
@dlzhry2nhs @dependabot
@Akol125 @mfjarvis @JamesW1-NHS @edhall-nhs @FimranNHS
Feature/ved 000 merge latest from master (#1216)
1503884 
* VED-1059 Made adjustment to batch queueing logic (#1189)

* Bump @redocly/cli from 2.15.1 to 2.16.0 in the npm-minor-patch group (#1188)

Bumps the npm-minor-patch group with 1 update: [@redocly/cli](https://github.com/Redocly/redocly-cli).


Updates `@redocly/cli` from 2.15.1 to 2.16.0
- [Release notes](https://github.com/Redocly/redocly-cli/releases)
- [Commits](https://github.com/Redocly/redocly-cli/compare/@redocly/cli@2.15.1...@redocly/cli@2.16.0)

---
updated-dependencies:
- dependency-name: "@redocly/cli"
  dependency-version: 2.16.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm-minor-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>

* OAS documentation for name field characters (#1190)

* VED-901: Update extended attribute file destination. (#1141)

* VED-901: Update extended attributes destination prefix.

* VED-901: Update tests.

* VED-901: Upload EA files directly to the S3 submission upload bucket.

* VED-901: Lint tfvars files.

* VED-1017: Generate JSON ACK file (#1168)

* init

* log bugfix

* interim: create_json_ack_file. pending new unit test and fixing old ones

* TEMP_ACK_FILE

* update_json_ack_file

* ingestion_start_time

* complete_batch_file_process

* obtain_current_json_ack_content

* cut/paste fix

* mock out get_ingestion_start_time_by_message_id

* fix & test get_ingestion_start_time_by_message_id

* bugfix

* bugfix split()[]

* test_update_ack_file

* test_complete_batch_file_process_json_ack_file II

* code cleanup

* extra mocks

* supplier

* restored move_file

* json ack file unit tests for lambda_handler (part 1)

* archive source file test - to support e2e testing

* remove redundant functions

* bugfix: get message_id from correct place for JSON ack file

* Trigger build

* bug fix: get_ingestion_start_time_by_message_id

* fixed filename in JSON ack file

* fixed filename in JSON ack file II

* supplier

* unit tests

* cleanup

* kick pipeline

* remove duplicate update_audit_table_item() call

* remove duplicate update_audit_table_item() call II

* review changes

* success -> succeeded

* _make_json_ack_file_row

* refactor json_ack_data helper functions

* _generated_date test values

* update_csv_ack_file

* obtain_current_csv_ack_content

* _generated_date comment

* _make_json_ack_data_row

* manual merge of e2e_automation from #1177

* Remove grafana code, dependabot, README references and sonar config (#1193)

* Bump @redocly/cli from 2.16.0 to 2.17.0 in the npm-minor-patch group (#1192)

Bumps the npm-minor-patch group with 1 update: [@redocly/cli](https://github.com/Redocly/redocly-cli).


Updates `@redocly/cli` from 2.16.0 to 2.17.0
- [Release notes](https://github.com/Redocly/redocly-cli/releases)
- [Commits](https://github.com/Redocly/redocly-cli/compare/@redocly/cli@2.16.0...@redocly/cli@2.17.0)

---
updated-dependencies:
- dependency-name: "@redocly/cli"
  dependency-version: 2.17.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm-minor-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>

* VED-000 [NOJIRA] Update Python dependencies. (#1196)

* VED-1039 Added the new vaccine types permitted for TPP and Optum (EMIS) (#1200)

* Bump @redocly/cli from 2.17.0 to 2.18.0 in the npm-minor-patch group (#1198)

Bumps the npm-minor-patch group with 1 update: [@redocly/cli](https://github.com/Redocly/redocly-cli).


Updates `@redocly/cli` from 2.17.0 to 2.18.0
- [Release notes](https://github.com/Redocly/redocly-cli/releases)
- [Commits](https://github.com/Redocly/redocly-cli/compare/@redocly/cli@2.17.0...@redocly/cli@2.18.0)

---
updated-dependencies:
- dependency-name: "@redocly/cli"
  dependency-version: 2.18.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm-minor-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>

* Bump @redocly/cli from 2.18.0 to 2.18.1 in the npm-minor-patch group (#1208)

* Bump @redocly/cli from 2.18.0 to 2.18.1 in the npm-minor-patch group

Bumps the npm-minor-patch group with 1 update: [@redocly/cli](https://github.com/Redocly/redocly-cli).


Updates `@redocly/cli` from 2.18.0 to 2.18.1
- [Release notes](https://github.com/Redocly/redocly-cli/releases)
- [Commits](https://github.com/Redocly/redocly-cli/compare/@redocly/cli@2.18.0...@redocly/cli@2.18.1)

---
updated-dependencies:
- dependency-name: "@redocly/cli"
  dependency-version: 2.18.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: npm-minor-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Trigger build

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>

* Bump the terraform-minor-patch group across 2 directories with 1 update (#1209)

Bumps the terraform-minor-patch group with 1 update in the /infrastructure/account directory: [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws).
Bumps the terraform-minor-patch group with 1 update in the /infrastructure/instance directory: [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws).


Updates `hashicorp/aws` from 6.31.0 to 6.32.1
- [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases)
- [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-provider-aws@v6.31.0...v6.32.1)

Updates `hashicorp/aws` from 6.31.0 to 6.32.1
- [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases)
- [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-provider-aws@v6.31.0...v6.32.1)

Updates `hashicorp/aws` from 6.31.0 to 6.32.1
- [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases)
- [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-provider-aws@v6.31.0...v6.32.1)

Updates `hashicorp/aws` from 6.31.0 to 6.32.1
- [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases)
- [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-provider-aws@v6.31.0...v6.32.1)

---
updated-dependencies:
- dependency-name: hashicorp/aws
  dependency-version: 6.32.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: terraform-minor-patch
- dependency-name: hashicorp/aws
  dependency-version: 6.32.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: terraform-minor-patch
- dependency-name: hashicorp/aws
  dependency-version: 6.32.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: terraform-minor-patch
- dependency-name: hashicorp/aws
  dependency-version: 6.32.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: terraform-minor-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>

* VED-1038 updated lint issue (#1207)

* updated the smoke tag and add scenarios as required in ticket

* ruff format

* fix the broken tests

* updated lint issue

* Update tests/e2e_automation/features/APITests/update.feature

Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>

* fix broken test by adding the valid vaccination in pre-condition

* fix lint issue

---------

Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>

* VED-981 Add base infrastructure for the MNS Publisher feature (#1191)

* VED-981 (Part 2) Add DLQ, redrive policy, and encryption to queues (#1203)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Akinola Olutola <akinola.olutola1@nhs.net>
Co-authored-by: Matt Jarvis <61870561+mfjarvis@users.noreply.github.com>
Co-authored-by: James W. <218585646+JamesW1-NHS@users.noreply.github.com>
Co-authored-by: Ed Hall <239591530+edhall-nhs@users.noreply.github.com>
Co-authored-by: FimranNHS <fatima.imran3@nhs.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dlzhry2nhs dlzhry2nhs dlzhry2nhs approved these changes

@JamesW1-NHS JamesW1-NHS JamesW1-NHS approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edhall-nhs @dlzhry2nhs @JamesW1-NHS

Comments