Skip to content

VED-1029: Set ACL when copying extended attributes files.#1199

Merged
mfjarvis merged 5 commits intomasterfrom
VED-1029-ea-set-acl
Feb 20, 2026
Merged

VED-1029: Set ACL when copying extended attributes files.#1199
mfjarvis merged 5 commits intomasterfrom
VED-1029-ea-set-acl

Conversation

@mfjarvis
Copy link
Copy Markdown
Contributor

@mfjarvis mfjarvis commented Feb 12, 2026

Summary

  • Routine Change

The S3 bucket we're copying to in the DSPP-Core AWS account has ACLs enabled, which means by default, our AWS account still owns the objects we upload to the bucket. This is causing issues as the Lambda function which is supposed to process those files then doesn't have permission to read them. We need to override the default ACL to bucket-owner-full-control, which will allow DPS to process the files.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
  • I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

@github-actions
Copy link
Copy Markdown
Contributor

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-1029

@mfjarvis mfjarvis temporarily deployed to internal-dev-sandbox February 19, 2026 13:41 — with GitHub Actions Inactive
@mfjarvis mfjarvis temporarily deployed to internal-dev-sandbox February 19, 2026 13:45 — with GitHub Actions Inactive
@mfjarvis mfjarvis temporarily deployed to internal-dev-sandbox February 19, 2026 13:46 — with GitHub Actions Inactive
@mfjarvis mfjarvis marked this pull request as ready for review February 20, 2026 13:38
@sonarqubecloud
Copy link
Copy Markdown

@mfjarvis mfjarvis enabled auto-merge (squash) February 20, 2026 14:19
@mfjarvis mfjarvis merged commit c1e84a9 into master Feb 20, 2026
24 of 25 checks passed
@mfjarvis mfjarvis deleted the VED-1029-ea-set-acl branch February 20, 2026 14:27
dlzhry2nhs pushed a commit that referenced this pull request Feb 24, 2026
* VED-1029: Set ACL when copying extended attributes files.

* VED-1029: Allow PutObjectAcl action.

* VED-1029: Change VPCE policy to allow PutObjectAcl action.
dlzhry2nhs pushed a commit that referenced this pull request Mar 9, 2026
* VED-1029: Set ACL when copying extended attributes files.

* VED-1029: Allow PutObjectAcl action.

* VED-1029: Change VPCE policy to allow PutObjectAcl action.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants