VED-1044: Create Cloudwatch Dashboard with Parameterised Terraform

[edhall-nhs]

Summary

🤖 Operational or Infrastructure Change

This is a follow on PR from #1201 that declares the dashboard within the terraform file as opposed to keeping the dashboard JSON config separate.

The previous approach is still valid and in some ways simpler but using variables based on the environment in terraform will help keep things more consistent across the AWS accounts.

NOTE: the PROD and PREPROD dashboards won't function as desired until the latest release due to some of the lambda names being changed.

Reviews Required

• Dev
• Test
• Tech Author
• Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

• I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
• If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
• If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
• I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

[github-actions]

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-1044

[dlzhry2nhs]

Looks good to me. 1 minor suggestion regarding the structure of our calculated variables for the dashboard.

One nice to have but can be deferred or ignored: it is possible to select on an individual component which Lambdas you want to display. However, there are quite a lot. Some food for thought, it would be really nice if you could filter all components so they only show resources for internal-dev or internal-qa. And the same would go for green and blue.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud