VED-1049: Make invalid -immunization.target behaviour consistent in the search API#1235
Merged
Thomas-Boyle merged 12 commits intomasterfrom Feb 25, 2026
Merged
VED-1049: Make invalid -immunization.target behaviour consistent in the search API#1235Thomas-Boyle merged 12 commits intomasterfrom
Thomas-Boyle merged 12 commits intomasterfrom
Conversation
- Added support for `invalid_immunization_targets` in `FhirController` and `FhirService`. - Updated `process_immunization_target` to return both valid and invalid vaccine types. - Modified `validate_and_retrieve_search_params` to include invalid targets in the search parameters. - Implemented logic to include an `OperationOutcome` in the response when invalid targets are provided. - Updated tests to cover scenarios for invalid immunization targets and ensure correct handling in search results.
Contributor
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-1049 |
Thomas-Boyle
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Thomas-Boyle
had a problem deploying
to
internal-dev
GitHub Actions
Failure
Thomas-Boyle
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Thomas-Boyle
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Thomas-Boyle
had a problem deploying
to
internal-dev
GitHub Actions
Failure
Thomas-Boyle
requested review from
Akol125,
JamesW1-NHS,
amarauzoma,
avshetty1980 and
dlzhry2nhs
Thomas-Boyle
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
Thomas-Boyle
had a problem deploying
to
internal-dev
GitHub Actions
Failure
edhall-nhs
previously approved these changes
Feb 24, 2026
Thomas-Boyle
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Thomas-Boyle
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
Thomas-Boyle
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
Thomas-Boyle
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Thomas-Boyle
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
Thomas-Boyle
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Thomas-Boyle
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
Thomas-Boyle
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
dlzhry2nhs
previously approved these changes
Feb 25, 2026
Contributor
dlzhry2nhs
left a comment
dlzhry2nhs
left a comment
There was a problem hiding this comment.
The code changes and new tests look good.
Just looks like you've got some linting issues. Is mentioned in the root README but the pre-commit hooks, installed with npm and defined in package.json will help to run the same things that are run in the repo.
Equally, can run from the quality_checks directory, but would recommend getting the pre-commit hooks in place.
Thomas-Boyle
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Thomas-Boyle
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Thomas-Boyle
force-pushed
the
ved-1049-pre-implementation
branch
from
bc7044e to
9699e48
Compare
Thomas-Boyle
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Thomas-Boyle
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
Thomas-Boyle
had a problem deploying
to
internal-dev
GitHub Actions
Failure
Thomas-Boyle
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Thomas-Boyle
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
|
dlzhry2nhs
approved these changes
Feb 25, 2026
avshetty1980
approved these changes
Feb 25, 2026
Contributor
avshetty1980
left a comment
avshetty1980
left a comment
There was a problem hiding this comment.
Nice! Looks really good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
invalid_immunization_targetsinFhirControllerandFhirService.process_immunization_targetto return both valid and invalid vaccine types.validate_and_retrieve_search_paramsto include invalid targets in the search parameters.OperationOutcomein the response when invalid targets are provided.