Skip to content

Ved 982 updated dpsfull batch scenario#1371

Merged
FimranNHS merged 3 commits intomasterfrom
VED-982-updated-DPSFULL-batch-scenario
Apr 1, 2026
Merged

Ved 982 updated dpsfull batch scenario#1371
FimranNHS merged 3 commits intomasterfrom
VED-982-updated-DPSFULL-batch-scenario

Conversation

@FimranNHS
Copy link
Copy Markdown
Contributor

@FimranNHS FimranNHS commented Apr 1, 2026

Summary

Batch File Enhancements

  • Added a new scenario for files received from the DPS side.
    This scenario validates that:
  • Immunisation events are correctly created in the Imms Event table with accurate data.
  • No records are created in the Delta table for this flow.
  • Refactored the patient age calculation logic to ensure it is derived correctly from both:
  • The CREATE event payload
  • The UPDATE event payload
    This ensures consistent and accurate age validation across all event types.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
  • I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-982

@avshetty1980
Copy link
Copy Markdown
Contributor

Could you please add a summary to the PR on what the update to the DPSFull batch is and perhaps in the title too?

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 1, 2026

@FimranNHS FimranNHS temporarily deployed to internal-dev-sandbox April 1, 2026 13:22 — with GitHub Actions Inactive
@FimranNHS FimranNHS temporarily deployed to internal-dev-sandbox April 1, 2026 13:23 — with GitHub Actions Inactive
@FimranNHS FimranNHS temporarily deployed to internal-dev-sandbox April 1, 2026 13:24 — with GitHub Actions Inactive
@FimranNHS FimranNHS enabled auto-merge (squash) April 1, 2026 13:47
@FimranNHS FimranNHS merged commit e082c48 into master Apr 1, 2026
18 checks passed
@FimranNHS FimranNHS deleted the VED-982-updated-DPSFULL-batch-scenario branch April 1, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants