Skip to content

Conversation

@Akol125
Copy link
Contributor

@Akol125 Akol125 commented Apr 1, 2025

Summary

  • ✨ New Feature
  1. Added a schema-driven conversion to Flat JSON for dateandtime, record date and expiry date
  2. Integrated a test_runner.py script for easy testing, which generates output.json and output.csv
  3. Wrote the README with clear usage steps and developer-friendly explanations

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

@Akol125 Akol125 changed the title fhir to flat json date conversion VED-163-fhir to flat json date conversion Apr 1, 2025
Copy link
Contributor

@nhsdevws nhsdevws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

summary name convention, lint errrors whitespace & line length.

Test file in src folder.

nhsdevws
nhsdevws previously approved these changes Apr 3, 2025
@Akol125 Akol125 requested a review from robertnovac1 April 3, 2025 10:10
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2025

@Akol125 Akol125 merged commit de82aea into master Apr 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants