Remove limit on number of outbound external attachments#130
Merged
adrianclay merged 2 commits intoNHSDigital:developfrom Sep 18, 2023
adrianclay:NIAD-2348/increase-number-of-external-attachments
Merged
Remove limit on number of outbound external attachments#130adrianclay merged 2 commits intoNHSDigital:developfrom adrianclay:NIAD-2348/increase-number-of-external-attachments
adrianclay merged 2 commits intoNHSDigital:developfrom
adrianclay:NIAD-2348/increase-number-of-external-attachments
Conversation
Contributor
Author
|
@benhession Having a look at the code, I can see no reason for the inbound to perform any validation on the number of external attachments. If you'd like me to add an automated test, I'd be happy to. |
adrianclay
commented
Sep 15, 2023
| self.assertEqual(response.code, 200) | ||
| self.assertEqual(response.headers["Correlation-Id"], CORRELATION_ID) | ||
|
|
||
| def test_request_with_10_000_doesnt_error(self): |
Contributor
Author
There was a problem hiding this comment.
I have a suspicion that these tests could be refactored a bit, but I didn't get a chance to look into this yet.
Happy to pick this up next week however.
adrianclay
changed the title
The original limit appeared erroneous, and not part of the specification
adrianclay
changed the title
MartinWheelerMT
approved these changes
Sep 18, 2023
adrianclay
deleted the
NIAD-2348/increase-number-of-external-attachments
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original limit appeared erroneous, and not part of the specification.
There exists a test which covers the limit for attachments, but no similar test for
external_attachmentsso I suspect that this validation code was indeed a mistake. Adding confidence to its removal.