NIAD-2822: Fix issue where incoming messages containing multibyte UTF-8 characters are mangled#137
Merged
adrianclay merged 2 commits intodevelopfrom Sep 6, 2023
Merged
Conversation
adrianclay
force-pushed
the
NIAD-2822-unit-test
branch
from
ced9681 to
2dc7f4e
Compare
ORybak5
approved these changes
Sep 5, 2023
MartinWheelerMT
approved these changes
Sep 5, 2023
adrianclay
force-pushed
the
NIAD-2822-unit-test
branch
from
2dc7f4e to
e5aebde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This appears to be an issue with the implementation of
email.message_from_string, a consise example of that issue has been created in this commit.In the meantime switch to the
email.message_from_bytesimplementation which doesn't suffer from this issue.