NIAD-2865: Inbound messages are stored on AMQP durably#148
Merged
adrianclay merged 5 commits intodevelopfrom Oct 17, 2023
Merged
NIAD-2865: Inbound messages are stored on AMQP durably#148adrianclay merged 5 commits intodevelopfrom
adrianclay merged 5 commits intodevelopfrom
Conversation
That way if the broker is restarted the message isn't lost.
MartinWheelerMT
previously approved these changes
Oct 17, 2023
The changes to send messages reliably are unlikely to have broken the MHS adaptors ability to process Asyncronous Reliable Messaging. The AsynchronousExpressMessagingPatternTests are executing the same change and are passing which provides evidence that this won't affect the ReliableMessagingPatternTests.
MartinWheelerMT
approved these changes
Oct 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Messages sent to the inbound AMQP are configured with durability. This means that the broker will try its hardest to keep the message, e.g. in the event of a reboot.
Why
These messages shouldn't be lost, as they can be part of clinically important data transfers, e.g. GP2GP
Type of change
Please delete options that are not relevant.
Checklist: