NIAD-3110: mhs resource assignment recommendation#158
Merged
adrianclay merged 2 commits intomainfrom Jun 7, 2024
Merged
Conversation
adrianclay
reviewed
Jun 3, 2024
| a step-by-step guide on how to set this up. | ||
|
|
||
| ## MHS Adaptor resource allocation | ||
| The recommended heap space for the PS Adaptor Translator is 4 GB. Also, it should be run on (at least) two CPUs for better performance. |
Contributor
There was a problem hiding this comment.
Would this not live better under the mhs/operating-mhs-adaptor.md file which is linked below under the title "Operational Considerations"?
Contributor
There was a problem hiding this comment.
Also "heap space" is a Java term, I don't think we're expecting our users to be Java experts or knowledgeable about this at all. I think our guidance should be in terms of Docker (which we do expect our users to be familiar with).
Contributor
Author
There was a problem hiding this comment.
ok, I will adjust the terminology to remove Java specific names.
adrianclay
approved these changes
Jun 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
MHS Adaptor resource assignment recommendation
Why
It is good to provide some guidance in terms of resource expectation
Type of change
Please delete options that are not relevant.
Checklist: