Wait for the ECS to fully deploy before finishing Terraform#159
Merged
adrianclay merged 3 commits intomainfrom Sep 9, 2024
Merged
Wait for the ECS to fully deploy before finishing Terraform#159adrianclay merged 3 commits intomainfrom
adrianclay merged 3 commits intomainfrom
Conversation
adrianclay
force-pushed
the
wait-for-deployment
branch
2 times, most recently
from
74c946e to
bd21d93
Compare
adrianclay
force-pushed
the
wait-for-deployment
branch
from
bd21d93 to
409630e
Compare
adrianclay
force-pushed
the
wait-for-deployment
branch
from
409630e to
c92f9ef
Compare
6 tasks
stevenmccullaghmadetech
previously approved these changes
Sep 2, 2024
This way we can ensure that the build pipeline is testing against the newly built image as opposed to the previous deployment. If deploying the service fails for whatever reason, the terraform command will fail too causing the build to fail.
adrianclay
force-pushed
the
wait-for-deployment
branch
from
c92f9ef to
c4ee860
Compare
adrianclay
force-pushed
the
wait-for-deployment
branch
from
c4ee860 to
0e39f2a
Compare
MartinWheelerMT
approved these changes
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This way we can ensure that the build pipeline is testing against the newly built image as opposed to the previous deployment.
If deploying the service fails for whatever reason, the terraform command will fail too causing the build to fail.
Type of change
[ ] Internal change (non-breaking change with no effect on the functionality affecting end users)
Checklist: