Skip to content

Remove the local-docker-compose-environment lock from Jenkins#173

Merged
adrianclay merged 1 commit intomainfrom
remove-lock-resources
Aug 14, 2024
Merged

Remove the local-docker-compose-environment lock from Jenkins#173
adrianclay merged 1 commit intomainfrom
remove-lock-resources

Conversation

@adrianclay
Copy link
Copy Markdown
Contributor

Why

Each build in Jenkins is run on its own EC2 instance, therefore any docker commands will only affect that EC2 instance.

The current global local-docker-compose-environment lock is preventing concurrency across EC2 instances.

This lock would only make sense if builds were being performed on the same Docker daemon.

Type of change

Internal change (non-breaking change with no effect on the functionality affecting end users)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users

Each build in Jenkins is run on its own EC2 instance, therefore
any docker commands will only affect that EC2 instance.

The current global local-docker-compose-environment lock is
preventing concurrency across EC2 instances.

This lock would only make sense if builds were being performed
on the same Docker daemon.
@adrianclay adrianclay enabled auto-merge (squash) August 9, 2024 10:41
@adrianclay adrianclay merged commit 3a08529 into main Aug 14, 2024
@adrianclay adrianclay deleted the remove-lock-resources branch August 14, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants