Skip to content

Remove the Docker base images#175

Merged
adrianclay merged 1 commit intomainfrom
remove-base-docker-images
Aug 9, 2024
Merged

Remove the Docker base images#175
adrianclay merged 1 commit intomainfrom
remove-base-docker-images

Conversation

@adrianclay
Copy link
Copy Markdown
Contributor

Why

There appears to be a 1-2-1 mapping between actual image, and base image.

This layer of indirection doesn't appear to be adding any value to the MHS Adaptor, and in fact makes it harder to release as there are two separate images for each of the inbound,outbound,sds.

By combining the base image into the actual image this will simplify maintenance for the developers.

Type of change

Internal change (non-breaking change with no effect on the functionality affecting end users)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users

There appears to be a 1-2-1 mapping between actual image, and base
image.

This layer of indirection doesn't appear to be adding any value to
the MHS Adaptor, and in fact makes it harder to release as there
are two separate images for each of the inbound,outbound,sds.

By combining the base image into the actual image this will
simplify maintenance for the developers.
@adrianclay adrianclay enabled auto-merge (squash) August 9, 2024 13:57
@adrianclay adrianclay merged commit bb31a39 into main Aug 9, 2024
@adrianclay adrianclay deleted the remove-base-docker-images branch August 9, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants