Remove the Docker base images#175
Merged
adrianclay merged 1 commit intomainfrom Aug 9, 2024
Merged
Conversation
There appears to be a 1-2-1 mapping between actual image, and base image. This layer of indirection doesn't appear to be adding any value to the MHS Adaptor, and in fact makes it harder to release as there are two separate images for each of the inbound,outbound,sds. By combining the base image into the actual image this will simplify maintenance for the developers.
Alex-Nita
approved these changes
Aug 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
There appears to be a 1-2-1 mapping between actual image, and base image.
This layer of indirection doesn't appear to be adding any value to the MHS Adaptor, and in fact makes it harder to release as there are two separate images for each of the inbound,outbound,sds.
By combining the base image into the actual image this will simplify maintenance for the developers.
Type of change
Internal change (non-breaking change with no effect on the functionality affecting end users)
Checklist: