Upgrade Pymongo throughout to resolve security notifications in dependabot#188
Merged
stevenmccullaghmadetech merged 7 commits intomainfrom Aug 19, 2024
Merged
Conversation
Alex-Nita
previously approved these changes
Aug 16, 2024
adrianclay
previously requested changes
Aug 18, 2024
Contributor
adrianclay
left a comment
There was a problem hiding this comment.
This PR doesn't seem to address the source of the outdated Pymongo, which is a very old version of motor within the common module.
I propose we instead upgrade that, instead of adding an additional dependency on pymongo everywhere.
Contributor
Author
|
@adrianclay Both the setup.py and Pipfile within the common module request motor 3.5.1 which is the latest tag of the repo you linked to and and the latest version here: https://pypi.org/project/motor/ |
Contributor
|
In that case I wouldn't bother with trying to fix the Dependabot alert. It appears to be only relevant when connecting to an untrusted Mongo server. |
Alex-Nita
previously approved these changes
Aug 19, 2024
Alex-Nita
previously approved these changes
Aug 19, 2024
Alex-Nita
approved these changes
Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Please include a summary of the changes and the related issue
Why
Please include details of the reasoning for these changes
Type of change
Please delete options that are not relevant.
Checklist: