Ask pystache to escape the attachment description for outbound#196
Merged
stevenmccullaghmadetech merged 4 commits intomainfrom Jan 7, 2025
Merged
Ask pystache to escape the attachment description for outbound#196stevenmccullaghmadetech merged 4 commits intomainfrom
stevenmccullaghmadetech merged 4 commits intomainfrom
Conversation
Pystache will use cgi.escape internally to map the following chars: - "<" -> "<" - ">" -> "&rt;" - "&" -> "&" Performing this will allow inbound descriptions to include these characters within the JSON, and result in valid XML being generated by the adaptor.
adrianclay
force-pushed
the
NIAD-3188
branch
2 times, most recently
from
a19a8b7 to
b411bf0
Compare
Pystache will use cgi.escape internally to map the following chars: - "<" -> "<" - ">" -> "&rt;" - "&" -> "&" Performing this will allow outbound descriptions to include these characters within the JSON, and result in valid XML being generated by the adaptor.
adrianclay
force-pushed
the
NIAD-3188
branch
from
b411bf0 to
eba908e
Compare
This reverts commit d9c3d84.
stevenmccullaghmadetech
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pystache will use cgi.escape internally to map the following chars:
<-><>->&rt;&->&Why
Performing this will allow inbound descriptions to include these characters within the JSON, and result in valid XML being generated by the adaptor.
Type of change
Bug fix (non-breaking change which fixes an issue)
Checklist: