NIAD-3252: External attachment filename containing equals sign throws exception

[MartinWheelerMT]

What

Updated the code using the split command in ebxml_envelope.py so that it only splits on the first occurence of = so that the full filename used and not attempted to be split further if it contains an =. This was also updated to not attempt to a process a provided variable if it is not a valid key value pair

Have also added tests to handle the following cases for the description:

• Invalid Description: <eb:Description>This isn't a GP2GP message</eb:Description>
• Duplicated key: <eb:Description>Filename=Value Filename=Value2</eb:Description>
• Case-sensitivity of filename: <eb:Description>FILENAME=Value Filename=Value2</eb:Description>
• Filename key-value pair is not provided

Why

If an attachment filename contains an equals sign (such as in the example below) then a error is currently thrown. This should be handled that a filename with an equals sign does not cause an issue.

<eb:Reference xlink:href="mid:E54DEC57-6BA5-40AB-ACD0-1E383209C034" eb:id="_735BB673-D9C0-4B85-951E-98DD045C4713" xmlns:xlink="http://www.w3.org/1999/xlink">
  <eb:Description xml:lang="en">Filename="735BB673-D9C0-4B85-951E-98DD045C4713_adrian=marbles2.BMP" ContentType=application/octet-stream Compressed=Yes LargeAttachment=No OriginalBase64=No Length=3345444</eb:Description>
</eb:Reference>

Also, from discussion, the following checks were required to make sure the adaptor throw errors in the following cases:

• Invalid Description: <eb:Description>This isn't a GP2GP message</eb:Description>
• Duplicated key: <eb:Description>Filename=Value Filename=Value2</eb:Description>
• Case-sensitivity of filename: <eb:Description>FILENAME=Value Filename=Value2</eb:Description>
• Filename key-value pair is not provided

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• I have performed a self-review of my code
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users

[adrianclay]

Minor feedback is that grouping the tests related to filenames under a common class might make it a bit more readable. May be easier to chat through my thinking though.