Skip to content

Update change log for attachment description escaping#225

Merged
stevenmccullaghmadetech merged 1 commit intomainfrom
NIAD-3188-changelog
Jan 14, 2025
Merged

Update change log for attachment description escaping#225
stevenmccullaghmadetech merged 1 commit intomainfrom
NIAD-3188-changelog

Conversation

@stevenmccullaghmadetech
Copy link
Copy Markdown
Contributor

What

Updating changelog for the Pystash file attachment escaping issue previously merged.

Why

Code was merged in previously to verify a fix, but change log needs updated to reflect the same.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users

Comment thread CHANGELOG.md

## [Unreleased]

- Fixed an issue where outbound request attachment filenames were not properly escaped.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this is a potentially breaking change, I think we should be a bit more specific about what outbound request attributes are affected, and what escaping is being performed, and that if you were previously escaping those fields in a similar way, you shouldn't do that anymore.

It might feel over the top, but helps create a sense to users that we care.

@stevenmccullaghmadetech stevenmccullaghmadetech merged commit 2db3564 into main Jan 14, 2025
@stevenmccullaghmadetech stevenmccullaghmadetech deleted the NIAD-3188-changelog branch January 14, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants