Update change log for attachment description escaping#225
Merged
stevenmccullaghmadetech merged 1 commit intomainfrom Jan 14, 2025
Merged
Update change log for attachment description escaping#225stevenmccullaghmadetech merged 1 commit intomainfrom
stevenmccullaghmadetech merged 1 commit intomainfrom
Conversation
Alex-Nita
approved these changes
Jan 13, 2025
adrianclay
reviewed
Jan 13, 2025
|
|
||
| ## [Unreleased] | ||
|
|
||
| - Fixed an issue where outbound request attachment filenames were not properly escaped. |
Contributor
There was a problem hiding this comment.
Because this is a potentially breaking change, I think we should be a bit more specific about what outbound request attributes are affected, and what escaping is being performed, and that if you were previously escaping those fields in a similar way, you shouldn't do that anymore.
It might feel over the top, but helps create a sense to users that we care.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updating changelog for the Pystash file attachment escaping issue previously merged.
Why
Code was merged in previously to verify a fix, but change log needs updated to reflect the same.
Type of change
Please delete options that are not relevant.
Checklist: