Address linting issues in Dockerfiles#371
Merged
MartinWheelerMT merged 13 commits intomainfrom Nov 28, 2025
Merged
Conversation
* Update `component-test.Dockerfile`.
MartinWheelerMT
force-pushed
the
address-dockerfile-linting
branch
from
fb0cda9 to
e67ee4d
Compare
* Update `docker/outbound/Dockerfile`.
* Update `integration-tests/fake_spine/Dockerfile`.
* Add `hadolint` to build pipeline.
MartinWheelerMT
force-pushed
the
address-dockerfile-linting
branch
from
e755bbb to
e50a134
Compare
* Address linting issues against `docker/inbound/Dockerfile`
* Address linting issues against `docker/spineroutelookup/Dockerfile`
* Comment line in Jenkinsfile for worker machine, until this file can be removed.
MartinWheelerMT
force-pushed
the
address-dockerfile-linting
branch
from
39ceade to
5b53ede
Compare
* Address linting issues in `integration-tests/fake_spineroutelookup/Dockerfile`
* Address linting issues in `docker/sds-api-mock/Dockerfile`
* Address linting issues in `docker/common/dynamodb-local/Dockerfile`
* Update wiremock to use offical image.
ORybak5
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
hadofilelinting to build pipeline.component-test.Dockerfile.docker/inbound/Dockerfile.integration-tests/fake_spine/Dockerfile.docker/inbound/Dockerfile.docker/spineroutelookup/Dockerfile.docker/sds-api-mock/Dockerfile.integration-tests/fake_spineroutelookup/Dockerfile.docker/common/dynamodb-local/Dockerfiledocker/common/dynamodb-local/Dockerfileto use officialwiremock/wiremockimagejenkins-workerDockerfile until this can be removed.Why
To follow best practices for container builds .
Type of change
Please delete options that are not relevant.
Checklist: