PPHA-570: component for phone and email usage#377
Merged
jamiefalcus merged 2 commits intomainfrom Mar 18, 2026
Merged
Conversation
Themitchell
previously approved these changes
Mar 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces reusable Jinja2 partials for the service phone number and contact email, and updates multiple question pages to use those components so contact details can be changed centrally via configuration.
Changes:
- Added
_phone_number.jinjaand_email_us.jinjapartial templates backed byCONTACT_NUMBER/CONTACT_EMAIL. - Replaced hardcoded / inline phone and email markup across several pages with
{% include %}calls. - Updated VS Code cSpell dictionary entries.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lung_cancer_screening/questions/jinja2/terms_of_use.jinja | Swaps hardcoded email link for shared email partial. |
| lung_cancer_screening/questions/jinja2/start.jinja | Swaps hardcoded phone link for shared phone partial (but exposes an HTML-structure issue in the same block). |
| lung_cancer_screening/questions/jinja2/contact_us.jinja | Refactors phone/email rendering to shared partials. |
| lung_cancer_screening/questions/jinja2/confirmation.jinja | Refactors phone rendering to shared partial. |
| lung_cancer_screening/questions/jinja2/book_an_appointment.jinja | Refactors phone rendering to shared partial. |
| lung_cancer_screening/questions/jinja2/agree_to_share_information.jinja | Refactors phone rendering to shared partial. |
| lung_cancer_screening/questions/jinja2/_phone_number.jinja | New shared phone-number link partial. |
| lung_cancer_screening/questions/jinja2/_email_us.jinja | New shared email link partial. |
| .vscode/settings.json | Adds domain-specific words to the spellchecker. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1f1a207 to
80c10b6
Compare
Themitchell
approved these changes
Mar 17, 2026
80c10b6 to
48aa9b1
Compare
48aa9b1 to
d7d05d8
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What is the change?
Adding phone and email components
Why are we making this change?
Allows us to more easily switch phone or email address in the future