Skip to content

PPHA-570: component for phone and email usage#377

Merged
jamiefalcus merged 2 commits intomainfrom
PPHA-570-phone-and-email-generic-usage
Mar 18, 2026
Merged

PPHA-570: component for phone and email usage#377
jamiefalcus merged 2 commits intomainfrom
PPHA-570-phone-and-email-generic-usage

Conversation

@jamiefalcus
Copy link
Copy Markdown
Contributor

What is the change?

Adding phone and email components

Why are we making this change?

Allows us to more easily switch phone or email address in the future

Copilot AI review requested due to automatic review settings March 17, 2026 15:45
Themitchell
Themitchell previously approved these changes Mar 17, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces reusable Jinja2 partials for the service phone number and contact email, and updates multiple question pages to use those components so contact details can be changed centrally via configuration.

Changes:

  • Added _phone_number.jinja and _email_us.jinja partial templates backed by CONTACT_NUMBER / CONTACT_EMAIL.
  • Replaced hardcoded / inline phone and email markup across several pages with {% include %} calls.
  • Updated VS Code cSpell dictionary entries.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
lung_cancer_screening/questions/jinja2/terms_of_use.jinja Swaps hardcoded email link for shared email partial.
lung_cancer_screening/questions/jinja2/start.jinja Swaps hardcoded phone link for shared phone partial (but exposes an HTML-structure issue in the same block).
lung_cancer_screening/questions/jinja2/contact_us.jinja Refactors phone/email rendering to shared partials.
lung_cancer_screening/questions/jinja2/confirmation.jinja Refactors phone rendering to shared partial.
lung_cancer_screening/questions/jinja2/book_an_appointment.jinja Refactors phone rendering to shared partial.
lung_cancer_screening/questions/jinja2/agree_to_share_information.jinja Refactors phone rendering to shared partial.
lung_cancer_screening/questions/jinja2/_phone_number.jinja New shared phone-number link partial.
lung_cancer_screening/questions/jinja2/_email_us.jinja New shared email link partial.
.vscode/settings.json Adds domain-specific words to the spellchecker.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lung_cancer_screening/questions/jinja2/start.jinja Outdated
Comment thread lung_cancer_screening/questions/jinja2/_phone_number.jinja
Comment thread lung_cancer_screening/questions/jinja2/_email_us.jinja
@jamiefalcus jamiefalcus force-pushed the PPHA-570-phone-and-email-generic-usage branch from 1f1a207 to 80c10b6 Compare March 17, 2026 15:59
@jamiefalcus jamiefalcus force-pushed the PPHA-570-phone-and-email-generic-usage branch from 80c10b6 to 48aa9b1 Compare March 18, 2026 09:25
@jamiefalcus jamiefalcus force-pushed the PPHA-570-phone-and-email-generic-usage branch from 48aa9b1 to d7d05d8 Compare March 18, 2026 09:32
@sonarqubecloud
Copy link
Copy Markdown

@jamiefalcus jamiefalcus merged commit 9d66390 into main Mar 18, 2026
25 checks passed
@jamiefalcus jamiefalcus deleted the PPHA-570-phone-and-email-generic-usage branch March 18, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants