Skip to content

Run Patient Status Updater for patient imports#6316

Merged
murugapl merged 2 commits intonextfrom
run-patient-status-updater-for-patient-imports
Mar 30, 2026
Merged

Run Patient Status Updater for patient imports#6316
murugapl merged 2 commits intonextfrom
run-patient-status-updater-for-patient-imports

Conversation

@MartinVanIJcken
Copy link
Copy Markdown
Contributor

This job should be ran also for patient imports, as a patient import may change the patient's year group which would affect their programme eligibility.

Jira Issue - MAV-5179

@MartinVanIJcken MartinVanIJcken requested a review from a team as a code owner March 16, 2026 14:00
@MartinVanIJcken MartinVanIJcken added the bug Something isn't working label Mar 16, 2026
@MartinVanIJcken MartinVanIJcken added this to the v7.6.0 milestone Mar 16, 2026
@MartinVanIJcken MartinVanIJcken force-pushed the run-patient-status-updater-for-patient-imports branch from 1b37335 to 2eadd6b Compare March 16, 2026 16:38
@MartinVanIJcken MartinVanIJcken changed the base branch from main to next March 16, 2026 16:48
Copy link
Copy Markdown
Contributor

@thomasleese thomasleese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test for this scenario? That way we can be certain that we won't end up with a regression if we refactor this in the future.

@murugapl murugapl force-pushed the run-patient-status-updater-for-patient-imports branch from 2eadd6b to 4570e82 Compare March 25, 2026 10:52
Comment thread spec/forms/import_duplicate_form_spec.rb Outdated
Comment thread spec/forms/import_duplicate_form_spec.rb Outdated
Comment thread spec/forms/import_duplicate_form_spec.rb Outdated
@murugapl murugapl force-pushed the run-patient-status-updater-for-patient-imports branch 2 times, most recently from 10fca1a to e242496 Compare March 25, 2026 14:35
@murugapl murugapl modified the milestones: v7.6.0, v7.7.0 Mar 25, 2026
@murugapl murugapl force-pushed the run-patient-status-updater-for-patient-imports branch from e242496 to 07f5697 Compare March 27, 2026 14:44
MartinVanIJcken and others added 2 commits March 30, 2026 15:56
This job should be ran also for patient imports, as a patient import may change
the patient's year group which would affect their programme eligibility.

Jira-Issue: MAV-5179
Call PatientStatusUpdater after applying or keeping both records in ImportDuplicateForm so that programme eligibility statuses reflect any pending changes (eg year group updates) committed during duplicate resolution.
@murugapl murugapl force-pushed the run-patient-status-updater-for-patient-imports branch from 07f5697 to 958a46d Compare March 30, 2026 14:58
@murugapl murugapl enabled auto-merge March 30, 2026 14:58
@murugapl murugapl merged commit 280d3fe into next Mar 30, 2026
13 checks passed
@murugapl murugapl deleted the run-patient-status-updater-for-patient-imports branch March 30, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants