mesh-2816: add automatic dependabot pr#157
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
johnwilliams57-nhs
left a comment
johnwilliams57-nhs
left a comment
There was a problem hiding this comment.
i've just added a couple of questions. also it's technically missing a comment
| steps: | ||
| - name: Fetch Dependabot metadata | ||
| id: metadata | ||
| uses: dependabot/fetch-metadata@ffa630c65fa7e0ecfa0625b5ceda64399aea1b36 |
There was a problem hiding this comment.
this should have the a comment after the sha:
#v3.0.0
(https://github.com/dependabot/fetch-metadata/releases/tag/v3.0.0)
| git merge --ff-only "${{ github.event.pull_request.head.sha }}" | ||
|
|
||
| - name: setup python | ||
| id: setup-python |
There was a problem hiding this comment.
seems fine to me. but out of interest, why've you added this id?
| publish: | ||
| runs-on: ubuntu-latest | ||
| if: github.repository == 'NHSDigital/mesh-client' && github.actor != 'dependabot[bot]' | ||
| if: github.repository == 'NHSDigital/mesh-client' && github.event.pull_request.user.login != 'dependabot[bot]' |
There was a problem hiding this comment.
i was expecting the changes to match mesh-sandbox here, but it doesn't:
https://github.com/NHSDigital/mesh-sandbox/blob/develop/.github/workflows/pull-request.yml#L241
is mesh-sandbox wrong?
|
2 participants
No description provided.