Conversation
# Conflicts: # lambdas/models/fhir/R4/nrl_fhir_document_reference.py # lambdas/services/nrl_get_document_reference_service.py # lambdas/tests/unit/services/test_nrl_get_document_reference_service.py
robg-nhs
reviewed
May 28, 2025
lambdas/enums/lambda_error.py
Outdated
| DocRefClient = { | ||
| "err_code": "DRS_5001", | ||
| "message": "An error occurred when searching for available documents", | ||
| "fhir_coding": FhirIssueCoding.NOT_FOUND, |
Contributor
There was a problem hiding this comment.
Is this the correct FhirIssueCoding,
The message seems vague the coding seems specific
Contributor
Author
There was a problem hiding this comment.
It would be an internal error. Which error code do you think is better suited?
https://build.fhir.org/codesystem-issue-type.html
Contributor
There was a problem hiding this comment.
<system value="http://hl7.org/fhir/issue-type">
<code value="exception">
<display value="Exception">
Comment on lines
+97
to
+100
| def _fetch_documents(self, nhs_number: str, table_name: str, filter_expression): | ||
| return self.fetch_documents_from_table_with_nhs_number( | ||
| nhs_number, table_name, query_filter=filter_expression | ||
| ) |
Contributor
There was a problem hiding this comment.
It feels a little bit overkill to have a _fetch_document followed by a _fetch_with_nhs_number method where the NHS Number is a required argument anyway.
| attachment=document_details, | ||
| ) | ||
| .create_minimal_fhir_document_reference_object() | ||
| .create_general_fhir_document_reference_object(document_reference) |
Contributor
There was a problem hiding this comment.
I feel general is a bit superflous.
create_fhir_document_reference_object should do
danielleandersonNHS
approved these changes
May 28, 2025
robg-nhs
approved these changes
May 29, 2025
# Conflicts: # lambdas/utils/decorators/validate_patient_id.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.