[PRM-393] Updated testing packages and fixed failing tests#676
Merged
chrisbloe-nhse merged 18 commits intomainfrom Jul 15, 2025
Merged
[PRM-393] Updated testing packages and fixed failing tests#676chrisbloe-nhse merged 18 commits intomainfrom
chrisbloe-nhse merged 18 commits intomainfrom
Conversation
app/src/components/blocks/_arf/selectStage/SelectStage.test.tsx
Outdated
Show resolved
Hide resolved
app/src/components/blocks/_arf/uploadingStage/UploadingStage.test.tsx
Outdated
Show resolved
Hide resolved
...mponents/blocks/_downloadReport/downloadReportSelectStage/DownloadReportSelectStage.test.tsx
Outdated
Show resolved
Hide resolved
jack-nhs
reviewed
Jul 8, 2025
.../components/blocks/_lloydGeorge/lloydGeorgeFileInputStage/LloydGeorgeFileInputStage.test.tsx
Show resolved
Hide resolved
app/src/components/blocks/_lloydGeorge/lloydGeorgeRecordError/LloydGeorgeRecordError.test.tsx
Show resolved
Hide resolved
...s/blocks/_lloydGeorge/lloydGeorgeSelectDownloadStage/LloydGeorgeSelectDownloadStage.test.tsx
Show resolved
Hide resolved
...s/blocks/_lloydGeorge/lloydGeorgeSelectSearchResults/LloydGeorgeSelectSearchResults.test.tsx
Show resolved
Hide resolved
...s/blocks/_lloydGeorge/lloydGeorgeUploadCompleteStage/LloydGeorgeUploadCompleteStage.test.tsx
Show resolved
Hide resolved
jack-nhs
approved these changes
Jul 8, 2025
...mponents/blocks/_downloadReport/downloadReportSelectStage/DownloadReportSelectStage.test.tsx
Outdated
Show resolved
Hide resolved
| cy.wait('@s3_retry_upload'); | ||
|
|
||
| cy.get('#upload-retry-button').should('exist'); | ||
| // eslint-disable-next-line cypress/no-unnecessary-waiting |
Contributor
There was a problem hiding this comment.
Should this be uncommented or removed?
Contributor
Author
There was a problem hiding this comment.
It's an upload issue again which is due to be rewritten by Adam.
| }); | ||
|
|
||
| it('does upload and then remove a file', async () => { | ||
| it.skip('does upload and then remove a file', async () => { |
Contributor
There was a problem hiding this comment.
What's the reason for skipping the tests in this file?
Contributor
Author
There was a problem hiding this comment.
The upload process is being rewritten by Adam he said skip any that cause an issue.
MohammadIqbalAD-NHS
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.