[PRME-79] Create Document Reference lambda #714

Merged

chrisbloe-nhse merged 27 commits intomainfrom

Aug 8, 2025

Contributor

kamenbachvarov-nhs commented Aug 4, 2025 •

edited

Loading

https://nhsd-jira.digital.nhs.uk/browse/PRME-79

Modified Create Document Reference (CDR) lambda and related logic with respective exceptions and handling.
Refactored Authoriser Service with more clarified variable names & added additional CDR endpoint logic - PCSE is now restricted from accessing CDR endpoint
CDR service now includes a check for allowed ODS codes that are going to be in the Uploads Pilot
SSM parameter added for ODS pilot codes at "/upload_pilot/ods_allowed_list"
Additional testing for all modified classes including the upload feature flag - improved code coverage

kamenbachvarov-nhs added 7 commits

July 29, 2025 13:42


          [PRME-79] Rename DocumentReference to CreateDocumentReference

63aed13


          [PRME-79] WIP authoriser changes for CreateDocumentReference

c797c6f


          [PRME-79] WIP changes to cdr and authoriser lambda handlers and servi…

b430624

…ces to cover some ACs


          [PRME-79] WIP non-pdf responses

3d3d678


          [PRME-79] WIP Refactor cdm tests for existing or currently uploading …

6bf3d4b

…lgrs


          [PRME-79] refactor auth service lambda; handle errors

88a30c2


          [PRME-79] refactor authoriser service to keep returning deny_resource

70500cc

kamenbachvarov-nhs temporarily deployed to development

August 4, 2025 09:45

— with

GitHub Actions Inactive

NogaNHS reviewed

View reviewed changes

lambdas/handlers/create_document_reference_handler.py Outdated Show resolved Hide resolved

NogaNHS reviewed

View reviewed changes

lambdas/services/authoriser_service.py Outdated Show resolved Hide resolved

NogaNHS reviewed

View reviewed changes

lambdas/services/authoriser_service.py Outdated Show resolved Hide resolved

NogaNHS reviewed

View reviewed changes

lambdas/services/create_document_reference_service.py Show resolved Hide resolved

NogaNHS reviewed

View reviewed changes

lambdas/services/create_document_reference_service.py Outdated Show resolved Hide resolved

NogaNHS reviewed

View reviewed changes

lambdas/services/create_document_reference_service.py Outdated Show resolved Hide resolved


          [PRME-79] add functionality for pilot allowed ods codes via ssm

6c09b73

kamenbachvarov-nhs temporarily deployed to development

August 4, 2025 11:21

— with

GitHub Actions Inactive


          [PRME-79] refactor to utilize handle_lambda_exceptions

dc7ca1d

kamenbachvarov-nhs temporarily deployed to development

August 4, 2025 13:17

— with

GitHub Actions Inactive


          [PRME-79] refactor names and exceptions re PR comments

c3f8134

kamenbachvarov-nhs temporarily deployed to development

August 4, 2025 13:24

— with

GitHub Actions Inactive


          [PRME-79] fix lambda error codes

81b0e00

kamenbachvarov-nhs temporarily deployed to development

August 4, 2025 13:27

— with

GitHub Actions Inactive


          [PRME-79] code cleanup

1cca416

kamenbachvarov-nhs temporarily deployed to development

August 4, 2025 13:53

— with

GitHub Actions Inactive


          Merge branch 'main' into PRME-79

4564a25

kamenbachvarov-nhs temporarily deployed to development

August 4, 2025 13:58

— with

GitHub Actions Inactive


          [PRME-79] code cleanup

f007f8f

kamenbachvarov-nhs temporarily deployed to development

August 4, 2025 14:04

— with

GitHub Actions Inactive


          [PRME-79] code cleanup

ff94114

kamenbachvarov-nhs temporarily deployed to development

August 4, 2025 14:07

— with

GitHub Actions Inactive

NogaNHS reviewed

View reviewed changes

lambdas/services/authoriser_service.py Outdated Show resolved Hide resolved

NogaNHS reviewed

View reviewed changes

lambdas/services/token_handler_ssm_service.py Outdated Show resolved Hide resolved


          [PRME-79] reafactor authoriser service logic and fix tests accordingly

974ee38

kamenbachvarov-nhs temporarily deployed to development

August 5, 2025 13:24

— with

GitHub Actions Inactive


          [PRME-79] refactor and code cleanup

c3bd96a

kamenbachvarov-nhs temporarily deployed to development

August 6, 2025 11:29

— with

GitHub Actions Inactive


          [PRME-79] remove token handler ssm service from cdr

7d7d235

kamenbachvarov-nhs temporarily deployed to development

August 6, 2025 11:35

— with

GitHub Actions Inactive


          Merge branch 'main' into PRME-79

9271a13

kamenbachvarov-nhs temporarily deployed to development

August 6, 2025 11:44

— with

GitHub Actions Inactive

kamenbachvarov-nhs marked this pull request as ready for review

August 6, 2025 11:45

lillie-dae approved these changes

View reviewed changes

lambdas/tests/unit/handlers/test_create_document_reference_handler.py Outdated Show resolved Hide resolved

lambdas/utils/lloyd_george_validator.py Show resolved Hide resolved


          revert lg filename validation & add feature flag deny policy

3fe5404

kamenbachvarov-nhs temporarily deployed to development

August 6, 2025 15:01

— with

GitHub Actions Inactive


          refactoring mock cdr service

9b80d36

kamenbachvarov-nhs temporarily deployed to development

August 6, 2025 15:13

— with

GitHub Actions Inactive


          fix validate_lg_files call

ae9c8dd

kamenbachvarov-nhs temporarily deployed to development

August 6, 2025 15:37

— with

GitHub Actions Inactive


          fix cdr service tests

a6606ef

kamenbachvarov-nhs temporarily deployed to development

August 6, 2025 15:43

— with

GitHub Actions Inactive


          revent patient search error code

558cebf

kamenbachvarov-nhs temporarily deployed to development

August 7, 2025 10:13

— with

GitHub Actions Inactive

NogaNHS approved these changes

View reviewed changes


          Merge branch 'main' into PRME-79

2cb05d5

kamenbachvarov-nhs temporarily deployed to development

August 7, 2025 14:49

— with

GitHub Actions Inactive

adamwhitingnhs reviewed

View reviewed changes

lambdas/services/create_document_reference_service.py Show resolved Hide resolved


          Merge branch 'main' into PRME-79

kamenbachvarov-nhs temporarily deployed to development

August 8, 2025 13:51

— with

GitHub Actions Inactive

chrisbloe-nhse merged commit 42b997c into main

12 checks passed

chrisbloe-nhse deleted the PRME-79 branch

August 8, 2025 14:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet