Skip to content

[PRMP-1142] Fix copy_across_bucket warnings in UT#962

Merged
kamenbachvarov-nhs merged 1 commit intomainfrom
PRMP-1142
Dec 18, 2025
Merged

[PRMP-1142] Fix copy_across_bucket warnings in UT#962
kamenbachvarov-nhs merged 1 commit intomainfrom
PRMP-1142

Conversation

@kamenbachvarov-nhs
Copy link
Contributor

@kamenbachvarov-nhs kamenbachvarov-nhs commented Dec 18, 2025

Overview

Jira ticket: 1142

Description

We've introduced some new warnings during UT in the test_upload_document_reference_service.py by starting to use the result of copy_across_bucket
This ticket is to apply the fix of actually mocking that result and particularly the VersionId so that we are back to warning free UT.

Checklist

Tasks for all changes:

  • 1. I have linked this PR to its Jira ticket.
  • 2. I have run git pre-commits. (WIP)
  • 3. I have added and/or updated relevant tests.
  • 4. I have updated relevant documentation.
  • 5. I have considered the cross-team impact (and have PR approval from both Core & Demographics if necessary).
  • 6. I have successfully deployed this change to a sandbox and witnessed unit and e2e tests passing:

@sonarqubecloud
Copy link

@github-actions
Copy link

Code security issues found

View full details here.

@kamenbachvarov-nhs kamenbachvarov-nhs merged commit 0d9e537 into main Dec 18, 2025
19 of 22 checks passed
@kamenbachvarov-nhs kamenbachvarov-nhs deleted the PRMP-1142 branch December 18, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants